Skip to content

DefaultAddToHistoryHandler filters too aggressively #3633

@lukeschlather

Description

@lukeschlather

Prerequisites

  • Write a descriptive title.

Description of the new feature/enhancement

So, per #1459 I don't really think this list of things to filter is a good heuristic. I often do things like:

$env:token = command-which-outputs-token ; command-which-requires-token-to-function

This filter breaks any sort of idiom like that since depending on the context it might be $env:secret, $env:password, or whatever. I just disable this and I don't think it should be on by default.

Proposed technical implementation details (optional)

Turn off this heuristic, it is very surprising behavior and doesn't really accomplish the intended goal.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions