Skip to content

Commit ea88142

Browse files
committed
Fixed wrong usage of ViewHolder pattern. Fixed bad practise when inflating views.
1 parent 3411d95 commit ea88142

1 file changed

Lines changed: 10 additions & 14 deletions

File tree

  • examples/adapterExample/src/main/java/io/realm/examples/realmadapters

examples/adapterExample/src/main/java/io/realm/examples/realmadapters/MyAdapter.java

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828

2929
public class MyAdapter extends RealmBaseAdapter<TimeStamp> implements ListAdapter {
3030

31-
private class MyViewHolder {
32-
TextView tvTimeStamp;
31+
private class ViewHolder {
32+
TextView timestamp;
3333
}
3434

3535
public MyAdapter(Context context, int resId, RealmResults<TimeStamp> realmResults, boolean automaticUpdate) {
@@ -38,25 +38,21 @@ public MyAdapter(Context context, int resId, RealmResults<TimeStamp> realmResult
3838

3939
@Override
4040
public View getView(int position, View convertView, ViewGroup parent) {
41-
MyViewHolder mViewHolder;
41+
ViewHolder viewHolder;
4242
if (convertView == null) {
43-
convertView = inflater.inflate(android.R.layout.simple_list_item_1, null);
44-
mViewHolder = new MyViewHolder();
45-
convertView.setTag(mViewHolder);
43+
convertView = inflater.inflate(android.R.layout.simple_list_item_1, parent, false);
44+
viewHolder = new ViewHolder();
45+
viewHolder.timestamp = (TextView) convertView.findViewById(android.R.id.text1);
46+
convertView.setTag(viewHolder);
4647
} else {
47-
mViewHolder = (MyViewHolder) convertView.getTag();
48+
viewHolder = (ViewHolder) convertView.getTag();
4849
}
4950

50-
mViewHolder.tvTimeStamp = detail(convertView, android.R.id.text1, realmResults.get(position).getTimeStamp());
51+
TimeStamp item = realmResults.get(position);
52+
viewHolder.timestamp.setText(item.getTimeStamp());
5153
return convertView;
5254
}
5355

54-
private TextView detail(View v, int resId, String text) {
55-
TextView tv = (TextView) v.findViewById(resId);
56-
tv.setText(text);
57-
return tv;
58-
}
59-
6056
public RealmResults<TimeStamp> getRealmResults() {
6157
return realmResults;
6258
}

0 commit comments

Comments
 (0)