Add functions into build.psm1 to Save and Restore PSOptions between different sessions. (PowerShell#6884)

kalgiz · TravisEz13 · commit 4070d51ee1dd · 2018-05-17T19:04:20.000-07:00
Add functions into build.psm1 to Save and Restore PSOptions between different sessions.
diff --git a/build.psm1 b/build.psm1
@@ -2808,6 +2808,45 @@ assembly
     }
 }
 
+# Save PSOptions to be restored by Restore-PSOptions
+function Save-PSOptions {
+    param(
+        [ValidateScript({$parent = Split-Path $_;if($parent){Test-Path $parent}else{return $true}})]
+        [ValidateNotNullOrEmpty()]
+        [string]
+        $PSOptionsPath = (Join-Path -Path $PSScriptRoot -ChildPath 'psoptions.json'),
+
+        [ValidateNotNullOrEmpty()]
+        [object]
+        $Options = (Get-PSOptions -DefaultToNew)
+    )
+
+    $Options | ConvertTo-Json -Depth 3 | Out-File -Encoding utf8 -FilePath $PSOptionsPath
+}
+
+# Restore PSOptions
+# Optionally remove the PSOptions file
+function Restore-PSOptions {
+    param(
+        [ValidateScript({Test-Path $_})]
+        [string]
+        $PSOptionsPath = (Join-Path -Path $PSScriptRoot -ChildPath 'psoptions.json'),
+        [switch]
+        $Remove
+    )
+
+    $options = Get-Content -Path $PSOptionsPath | ConvertFrom-Json
+
+    if($Remove)
+    {
+        # Remove PSOptions.
+        # The file is only used to set the PSOptions.
+        Remove-Item -Path $psOptionsPath
+    }
+
+    Set-PSOptions -Options $options
+}
+
 $script:RESX_TEMPLATE = @'
 <?xml version="1.0" encoding="utf-8"?>
 <root>
diff --git a/tools/packaging/packaging.psm1 b/tools/packaging/packaging.psm1
@@ -180,7 +180,7 @@ function Start-PSPackage {
                 # Zip symbols.zip to the root package
                 $zipSource = Join-Path $symbolsSource -ChildPath '*'
                 $zipPath = Join-Path -Path $Source -ChildPath 'symbols.zip'
-                $Script:Options | ConvertTo-Json -Depth 3 | Out-File -Encoding utf8 -FilePath (Join-Path -Path $source -ChildPath 'psoptions.json')
+                Save-PSOptions -PSOptionsPath (Join-Path -Path $source -ChildPath 'psoptions.json') -Options $Script:Options
                 Compress-Archive -Path $zipSource -DestinationPath $zipPath
             }
             finally
@@ -493,11 +493,9 @@ function Expand-PSSignedBuild
     Restore-PSModuleToBuild -PublishPath $buildPath
 
     $psOptionsPath = Join-Path $buildPath -ChildPath 'psoptions.json'
-    $options = Get-Content -Path $psOptionsPath | ConvertFrom-Json
+    Restore-PSOptions -PSOptionsPath $psOptionsPath -Remove
 
-    # Remove PSOptions.
-    # The file is only used to set the PSOptions.
-    Remove-Item -Path $psOptionsPath
+    $options = Get-PSOptions
 
     $options.PSModuleRestore = $true
 
diff --git a/tools/releaseBuild/setReleaseTag.ps1 b/tools/releaseBuild/setReleaseTag.ps1
@@ -14,6 +14,7 @@ param(
 # VSTS passes it as 'refs/heads/release-v6.0.2'
 
 $branchOnly = $Branch -replace '^refs/heads/';
+$branchOnly = $branchOnly -replace '[_\-]'
 
 if($ReleaseTag -eq 'fromBranch' -or !$ReleaseTag)
 {

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@ param(`
`14`	`14`	`# VSTS passes it as 'refs/heads/release-v6.0.2'`
`15`	`15`
`16`	`16`	`$branchOnly = $Branch -replace '^refs/heads/';`
	`17`	`+$branchOnly = $branchOnly -replace '[_\-]'`
`17`	`18`
`18`	`19`	`if($ReleaseTag -eq 'fromBranch' -or !$ReleaseTag)`
`19`	`20`	`{`