[IMP] Improve naming

apineux · apineux · commit 649f91a92b5f · 2019-05-24T12:06:19.000+02:00
diff --git a/base_export_async/data/config_parameter.xml b/base_export_async/data/config_parameter.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo noupdate="1">
-    <record id="attachment_time_to_live" model="ir.config_parameter">
-        <field name="key">attachment.time.to.live</field>
+    <record id="attachment_ttl" model="ir.config_parameter">
+        <field name="key">attachment.ttl</field>
         <field name="value">7</field>
     </record>
 </odoo>
diff --git a/base_export_async/models/delay_export.py b/base_export_async/models/delay_export.py
@@ -86,11 +86,12 @@ def export(self, params):
         )
 
         time_to_live = self.env['ir.config_parameter'].sudo(). \
-            get_param('attachment.time.to.live', 7)
+            get_param('attachment.ttl', 7)
         date_today = fields.Date.today()
         expiration_date = fields.Date.to_string(
             date_today + relativedelta(days=+int(time_to_live)))
 
+        # TODO : move to email template
         odoo_bot = self.sudo().env.ref("base.partner_root")
         email_from = odoo_bot.email
         self.env['mail.mail'].create({
@@ -112,8 +113,8 @@ def export(self, params):
 
     @api.model
     def cron_delete(self):
-        time_to_live = self.env. \
-            ref('base_export_async.attachment_time_to_live').value
+        time_to_live = self.env['ir.config_parameter'].sudo(). \
+            get_param('attachment.ttl', 7)
         date_today = fields.Date.today()
         date_to_delete = date_today + relativedelta(days=-int(time_to_live))
         self.search([('create_date', '<=', date_to_delete)]).unlink()
diff --git a/base_export_async/tests/test_base_export_async.py b/base_export_async/tests/test_base_export_async.py
@@ -73,7 +73,7 @@ def test_cron_delete(self):
         self.delay_export_obj.export(params)
         new_attachment = self.env['ir.attachment'].search([]) - attachments
         time_to_live = self.env['ir.config_parameter'].sudo(). \
-            get_param('attachment.time.to.live', 7)
+            get_param('attachment.ttl', 7)
         date_today = fields.Date.today()
         date_to_delete = date_today + relativedelta(days=-int(time_to_live))
         # Update create_date with today - TTL
