Checks if commander has a relationship to an oncall service before attempting to page (Netflix#2493)

mvilanova · web-flow · commit e98199f0f646 · 2022-09-06T10:40:27.000-07:00
* Do not attempt to page commander if not mapped to an oncall service

* Removes noqa
diff --git a/src/dispatch/incident/flows.py b/src/dispatch/incident/flows.py
@@ -945,19 +945,24 @@ def incident_create_flow(*, organization_slug: str, incident_id: int, db_session
 
     # we page the incident commander based on incident priority
     if incident.incident_priority.page_commander:
-        service_id = incident.commander.service.external_id
-        oncall_plugin = plugin_service.get_active_instance(
-            db_session=db_session, project_id=incident.project.id, plugin_type="oncall"
-        )
-        if oncall_plugin:
-            oncall_plugin.instance.page(
-                service_id=service_id,
-                incident_name=incident.name,
-                incident_title=incident.title,
-                incident_description=incident.description,
+        if incident.commander.service:
+            service_id = incident.commander.service.external_id
+            oncall_plugin = plugin_service.get_active_instance(
+                db_session=db_session, project_id=incident.project.id, plugin_type="oncall"
             )
+            if oncall_plugin:
+                oncall_plugin.instance.page(
+                    service_id=service_id,
+                    incident_name=incident.name,
+                    incident_title=incident.title,
+                    incident_description=incident.description,
+                )
+            else:
+                log.warning("Incident commander not paged. No plugin of type oncall enabled.")
         else:
-            log.warning("Incident commander not paged. No plugin of type oncall enabled.")
+            log.warning(
+                "Incident commander not paged. No relationship between commander and an oncall service."
+            )
 
     # we send a message to the incident commander with tips on how to manage the incident
     send_incident_management_help_tips_message(incident, db_session)
