From 8ef933126b30c24746422268b00f616a46602603 Mon Sep 17 00:00:00 2001 From: "pixeebot[bot]" <104101892+pixeebot[bot]@users.noreply.github.com> Date: Sat, 9 Aug 2025 03:03:23 +0000 Subject: [PATCH] Sandbox Process Creation --- ncdssdk/src/tests/RunTests.py | 9 +++++---- requirements.txt | 3 ++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/ncdssdk/src/tests/RunTests.py b/ncdssdk/src/tests/RunTests.py index 9e44775..b2ff762 100644 --- a/ncdssdk/src/tests/RunTests.py +++ b/ncdssdk/src/tests/RunTests.py @@ -9,6 +9,7 @@ make_zookeeper_process, make_kafka_server, make_kafka_consumer, terminate, ) +from security import safe_command ROOT = Path(__file__).parent.parent.parent.parent THIS_DIR = Path(__file__).parent @@ -25,7 +26,7 @@ def test_integration(kafka_server: Tuple[Popen, int]): RUN_TESTS_CMD = ['pytest', '-s', THIS_DIR / 'NCDSSDKPyTest.py'] - test_process = subprocess.Popen(RUN_TESTS_CMD) + test_process = safe_command.run(subprocess.Popen, RUN_TESTS_CMD) test_process.wait() delete_test_topics() sleep(5) @@ -40,6 +41,6 @@ def delete_test_topics(): delete_gids_topic_cmd = [str(KAFKA_SCRIPTS) + "/kafka-topics.sh", "--zookeeper", "localhost:2181", "--delete", "--topic", "GIDS.stream"] - subprocess.Popen(delete_ctrl_topic_cmd) - subprocess.Popen(delete_mock_topic_cmd) - subprocess.Popen(delete_gids_topic_cmd) \ No newline at end of file + safe_command.run(subprocess.Popen, delete_ctrl_topic_cmd) + safe_command.run(subprocess.Popen, delete_mock_topic_cmd) + safe_command.run(subprocess.Popen, delete_gids_topic_cmd) diff --git a/requirements.txt b/requirements.txt index 60e74d9..5a9edc3 100644 --- a/requirements.txt +++ b/requirements.txt @@ -34,4 +34,5 @@ urllib3==1.26.6 # via requests zipp==3.4.1 # via importlib-metadata -pytz==2023.3 \ No newline at end of file +pytz==2023.3 +security==1.3.1