Default spaceMin/spaceMax for bar charts

danielgindi · danielgindi · commit 8d655962661f · 2016-10-08T22:25:44.000+03:00
This avoids having to set custom axisMinimum/axisMaximum, or offsetting x
diff --git a/MPChartExample/src/com/xxmassdeveloper/mpchartexample/BarChartActivity.java b/MPChartExample/src/com/xxmassdeveloper/mpchartexample/BarChartActivity.java
@@ -231,15 +231,12 @@ private void setData(int count, float range) {
 
         float start = 0f;
 
-        mChart.getXAxis().setAxisMinimum(start);
-        mChart.getXAxis().setAxisMaximum(start + count + 2);
-
         ArrayList<BarEntry> yVals1 = new ArrayList<BarEntry>();
 
         for (int i = (int) start; i < start + count + 1; i++) {
             float mult = (range + 1);
             float val = (float) (Math.random() * mult);
-            yVals1.add(new BarEntry(i + 1f, val));
+            yVals1.add(new BarEntry(i, val));
         }
 
         BarDataSet set1;
diff --git a/MPChartExample/src/com/xxmassdeveloper/mpchartexample/BarChartPositiveNegative.java b/MPChartExample/src/com/xxmassdeveloper/mpchartexample/BarChartPositiveNegative.java
@@ -61,8 +61,6 @@ protected void onCreate(Bundle savedInstanceState) {
         xAxis.setDrawAxisLine(false);
         xAxis.setTextColor(Color.LTGRAY);
         xAxis.setTextSize(13f);
-        xAxis.setAxisMinimum(0f);
-        xAxis.setAxisMaximum(5f);
         xAxis.setLabelCount(5);
         xAxis.setCenterAxisLabels(true);
         xAxis.setGranularity(1f);
@@ -81,11 +79,11 @@ protected void onCreate(Bundle savedInstanceState) {
 
         // THIS IS THE ORIGINAL DATA YOU WANT TO PLOT
         final List<Data> data = new ArrayList<>();
-        data.add(new Data(0.5f, -224.1f, "12-29"));
-        data.add(new Data(1.5f, 238.5f, "12-30"));
-        data.add(new Data(2.5f, 1280.1f, "12-31"));
-        data.add(new Data(3.5f, -442.3f, "01-01"));
-        data.add(new Data(4.5f, -2280.1f, "01-02"));
+        data.add(new Data(0f, -224.1f, "12-29"));
+        data.add(new Data(1f, 238.5f, "12-30"));
+        data.add(new Data(2f, 1280.1f, "12-31"));
+        data.add(new Data(3f, -442.3f, "01-01"));
+        data.add(new Data(4f, -2280.1f, "01-02"));
 
         xAxis.setValueFormatter(new IAxisValueFormatter() {
             @Override
diff --git a/MPChartLib/src/main/java/com/github/mikephil/charting/charts/BarChart.java b/MPChartLib/src/main/java/com/github/mikephil/charting/charts/BarChart.java
@@ -57,6 +57,9 @@ protected void init() {
         mRenderer = new BarChartRenderer(this, mAnimator, mViewPortHandler);
 
         setHighlighter(new BarHighlighter(this));
+
+        getXAxis().setSpaceMin(0.5f);
+        getXAxis().setSpaceMax(0.5f);
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,9 @@ protected void init() {`
`57`	`57`	`mRenderer = new BarChartRenderer(this, mAnimator, mViewPortHandler);`
`58`	`58`
`59`	`59`	`setHighlighter(new BarHighlighter(this));`
	`60`	`+`
	`61`	`+ getXAxis().setSpaceMin(0.5f);`
	`62`	`+ getXAxis().setSpaceMax(0.5f);`
`60`	`63`	`}`
`61`	`64`
`62`	`65`	`@Override`