Skip to content

Commit 82299e9

Browse files
committed
Refactor api and add comments.
1 parent 88590c2 commit 82299e9

5 files changed

Lines changed: 17 additions & 14 deletions

File tree

Example/MessageDisplayExample/MessageDisplayExample/XHDemoWeChatMessageTableViewController.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -284,16 +284,16 @@ - (BOOL)shouldLoadMoreMessagesScrollToTop {
284284
}
285285

286286
- (void)loadMoreMessagesScrollTotop {
287-
if (!self.loadMoreMessage) {
288-
self.loadMoreMessage = YES;
287+
if (!self.loadingMoreMessage) {
288+
self.loadingMoreMessage = YES;
289289

290290
WEAKSELF
291291
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
292292
NSMutableArray *messages = [weakSelf getTestMessages];
293293
sleep(2);
294294
dispatch_async(dispatch_get_main_queue(), ^{
295295
[weakSelf insertOldMessages:messages];
296-
weakSelf.loadMoreMessage = NO;
296+
weakSelf.loadingMoreMessage = NO;
297297
});
298298
});
299299
}

Example/MessageDisplayKitCoreDataExample/MessageDisplayKitCoreDataExample/XHDemoWeChatMessageTableViewController.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -402,16 +402,16 @@ - (BOOL)shouldLoadMoreMessagesScrollToTop {
402402
}
403403

404404
- (void)loadMoreMessagesScrollTotop {
405-
if (!self.loadMoreMessage) {
406-
self.loadMoreMessage = YES;
405+
if (!self.loadingMoreMessage) {
406+
self.loadingMoreMessage = YES;
407407

408408
WEAKSELF
409409
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
410410
NSMutableArray *messages = [weakSelf getTestMessages];
411411
sleep(3);
412412
dispatch_async(dispatch_get_main_queue(), ^{
413413
[weakSelf insertOldMessages:messages];
414-
weakSelf.loadMoreMessage = NO;
414+
weakSelf.loadingMoreMessage = NO;
415415
});
416416
});
417417
}

Example/MessageDisplayKitStoryBoradExample/MessageDisplayKitStoryBoradExample/XHDemoWeChatMessageTableViewController.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -247,16 +247,16 @@ - (BOOL)shouldLoadMoreMessagesScrollToTop {
247247
}
248248

249249
- (void)loadMoreMessagesScrollTotop {
250-
if (!self.loadMoreMessage) {
251-
self.loadMoreMessage = YES;
250+
if (!self.loadingMoreMessage) {
251+
self.loadingMoreMessage = YES;
252252

253253
WEAKSELF
254254
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
255255
NSMutableArray *messages = [weakSelf getTestMessages];
256256
sleep(3);
257257
dispatch_async(dispatch_get_main_queue(), ^{
258258
[weakSelf insertOldMessages:messages];
259-
weakSelf.loadMoreMessage = NO;
259+
weakSelf.loadingMoreMessage = NO;
260260
});
261261
});
262262
}

MessageDisplayKit/Classes/Controllers/XHMessageTableViewController/XHMessageTableViewController.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,10 @@
181181
*/
182182
@property (nonatomic, weak, readonly) XHEmotionManagerView *emotionManagerView;
183183

184-
@property (nonatomic, assign) BOOL loadMoreMessage;
184+
/**
185+
* 是否正在加载更多旧的消息数据
186+
*/
187+
@property (nonatomic, assign) BOOL loadingMoreMessage;
185188

186189
#pragma mark - Message View Controller Default stup
187190
/**

MessageDisplayKit/Classes/Controllers/XHMessageTableViewController/XHMessageTableViewController.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -309,9 +309,9 @@ - (UIActivityIndicatorView *)loadMoreActivityIndicatorView {
309309
}
310310
return _loadMoreActivityIndicatorView;
311311
}
312-
- (void)setLoadMoreMessage:(BOOL)loadMoreMessage {
313-
_loadMoreMessage = loadMoreMessage;
314-
if (loadMoreMessage) {
312+
- (void)setLoadingMoreMessage:(BOOL)loadingMoreMessage {
313+
_loadingMoreMessage = loadingMoreMessage;
314+
if (loadingMoreMessage) {
315315
[self.loadMoreActivityIndicatorView startAnimating];
316316
} else {
317317
[self.loadMoreActivityIndicatorView stopAnimating];
@@ -1116,7 +1116,7 @@ - (void)scrollViewDidScroll:(UIScrollView *)scrollView {
11161116
BOOL shouldLoadMoreMessages = [self.delegate shouldLoadMoreMessagesScrollToTop];
11171117
if (shouldLoadMoreMessages) {
11181118
if (scrollView.contentOffset.y >=0 && scrollView.contentOffset.y <= 44) {
1119-
if (!self.loadMoreMessage) {
1119+
if (!self.loadingMoreMessage) {
11201120
if ([self.delegate respondsToSelector:@selector(loadMoreMessagesScrollTotop)]) {
11211121
[self.delegate loadMoreMessagesScrollTotop];
11221122
}

0 commit comments

Comments
 (0)