rename DebugTree for clarity, move out of PDEX

benfry · benfry · commit 69718c6f292b · 2020-01-28T10:34:24.000-05:00
diff --git a/java/src/processing/mode/java/ASTViewer.java b/java/src/processing/mode/java/ASTViewer.java
@@ -24,13 +24,13 @@
 import processing.mode.java.PreprocessedSketch.SketchInterval;
 
 
-class DebugTree {
+class ASTViewer {
   final JDialog window;
   final JTree tree;
   final Consumer<PreprocessedSketch> updateListener;
 
 
-  DebugTree(JavaEditor editor, PreprocessingService pps) {
+  ASTViewer(JavaEditor editor, PreprocessingService pps) {
     updateListener = this::buildAndUpdateTree;
 
     window = new JDialog(editor);
diff --git a/java/src/processing/mode/java/JavaEditor.java b/java/src/processing/mode/java/JavaEditor.java
@@ -90,6 +90,10 @@ public class JavaEditor extends Editor {
   protected PreprocessingService preprocessingService;
   protected PDEX pdex;
 
+  // set true to show AST debugging window
+  static private final boolean SHOW_AST_VIEWER = false;
+  private ASTViewer astViewer;
+
 
   protected JavaEditor(Base base, String path, EditorState state,
                        Mode mode) throws EditorException {
@@ -128,6 +132,10 @@ protected JavaEditor(Base base, String path, EditorState state,
     preprocessingService = new PreprocessingService(this);
     pdex = new PDEX(this, preprocessingService);
 
+    if (SHOW_AST_VIEWER) {
+      astViewer = new ASTViewer(this, preprocessingService);
+    }
+
     Toolkit.setMenuMnemonics(textarea.getRightClickPopup());
 
     // ensure completion is hidden when editor loses focus
@@ -1338,6 +1346,9 @@ public void dispose() {
     }
     preprocessingService.dispose();
     pdex.dispose();
+    if (astViewer != null) {
+      astViewer.dispose();
+    }
     super.dispose();
   }
 
diff --git a/java/src/processing/mode/java/PDEX.java b/java/src/processing/mode/java/PDEX.java
@@ -8,16 +8,13 @@
 
 
 public class PDEX {
-  static private final boolean SHOW_DEBUG_TREE = false;
-
   private boolean enabled = true;
 
   private ErrorChecker errorChecker;
 
   private InspectMode inspect;
   private ShowUsage usage;
   private Rename rename;
-  private DebugTree debugTree;
 
   private PreprocessingService pps;
 
@@ -33,10 +30,6 @@ public PDEX(JavaEditor editor, PreprocessingService pps) {
     inspect = new InspectMode(editor, pps, usage);
     rename = new Rename(editor, pps, usage);
 
-    if (SHOW_DEBUG_TREE) {
-      debugTree = new DebugTree(editor, pps);
-    }
-
     for (SketchCode code : editor.getSketch().getCode()) {
       Document document = code.getDocument();
       addDocumentListener(document);
@@ -47,26 +40,25 @@ public PDEX(JavaEditor editor, PreprocessingService pps) {
 
 
   public void addDocumentListener(Document doc) {
-    if (doc != null) doc.addDocumentListener(sketchChangedListener);
-  }
-
-
-  final DocumentListener sketchChangedListener = new DocumentListener() {
-    @Override
-    public void insertUpdate(DocumentEvent e) {
-      sketchChanged();
+    if (doc != null) {
+      doc.addDocumentListener(new DocumentListener() {
+        @Override
+        public void insertUpdate(DocumentEvent e) {
+          sketchChanged();
+        }
+
+        @Override
+        public void removeUpdate(DocumentEvent e) {
+          sketchChanged();
+        }
+
+        @Override
+        public void changedUpdate(DocumentEvent e) {
+          sketchChanged();
+        }
+      });
     }
-
-    @Override
-    public void removeUpdate(DocumentEvent e) {
-      sketchChanged();
-    }
-
-    @Override
-    public void changedUpdate(DocumentEvent e) {
-      sketchChanged();
-    }
-  };
+  }
 
 
   public void sketchChanged() {
@@ -94,9 +86,6 @@ public void dispose() {
     errorChecker.dispose();
     usage.dispose();
     rename.dispose();
-    if (debugTree != null) {
-      debugTree.dispose();
-    }
   }
 
 
