[fix] logging errors even though response was ok

ibrahimlawal · ibrahimlawal · commit 008105daafdf · 2017-01-30T13:57:47.000+01:00
diff --git a/src/Paystack/Http/Response.php b/src/Paystack/Http/Response.php
@@ -36,12 +36,12 @@ public function wrapUp()
             return $this->parsePaystackResponse();
         }
         if (!$this->okay && $this->forApi) {
-            throw new Exception($this->implodedMessages());
+            throw new \Exception($this->implodedMessages());
         }
         if ($this->okay) {
-            error_log($this->implodedMessages());
             return $this->body;
         }
+        error_log($this->implodedMessages());
         return false;
     }
 }
diff --git a/tests/Http/ResponseTest.php b/tests/Http/ResponseTest.php
@@ -2,6 +2,7 @@
 namespace Yabacon\Paystack\Tests\Http;
 
 use Yabacon\Paystack\Http\Response;
+use Yabacon\Paystack\Exception\ApiException;
 
 class ResponseTest extends \PHPUnit_Framework_TestCase
 {
@@ -10,4 +11,71 @@ public function testInitialize()
         $r = new Response();
         $this->assertNotNull($r);
     }
+
+    public function testWrapUpForApiOkay()
+    {
+        $r = new Response();
+        $r->okay = true;
+        $r->forApi = true;
+        $r->body = '{"status":"1","data":{"status":"okay"}}';
+
+        $resp = $r->wrapUp();
+        $this->assertEquals('okay', $resp->data->status);
+    }
+
+    public function testWrapUpForApiOkayStatusFalse()
+    {
+        $r = new Response();
+        $r->okay = true;
+        $r->forApi = true;
+        $r->body = '{"status":"0","message":"I failed on Api","data":{"status":"okay"}}';
+
+        $this->expectException(ApiException::class);
+        $resp = $r->wrapUp();
+        $this->assertEquals('I failed on Api', $resp->message);
+    }
+
+    public function testWrapUpForApiOkayBadJSON()
+    {
+        $r = new Response();
+        $r->okay = true;
+        $r->forApi = true;
+        $r->body = 'API didn\'t give JSON';
+
+        $this->expectException(ApiException::class);
+        $resp = $r->wrapUp();
+    }
+
+    public function testWrapUpForApiNotOkay()
+    {
+        $r = new Response();
+        $r->okay = false;
+        $r->forApi = true;
+        $r->body = 'I failed before hitting API';
+
+        $this->expectException(\Exception::class);
+        $resp = $r->wrapUp();
+    }
+
+    public function testWrapUpNotForApiOkay()
+    {
+        $r = new Response();
+        $r->okay = true;
+        $r->forApi = false;
+        $r->body = 'I was not sent to API';
+
+        $resp = $r->wrapUp();
+        $this->assertEquals('I was not sent to API', $resp);
+    }
+
+    public function testWrapUpNotForApiNotOkay()
+    {
+        $r = new Response();
+        $r->okay = false;
+        $r->forApi = false;
+        $r->body = 'I was not sent to API but I still failed';
+
+        $resp = $r->wrapUp();
+        $this->assertFalse($resp);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -36,12 +36,12 @@ public function wrapUp()`
`36`	`36`	`return $this->parsePaystackResponse();`
`37`	`37`	`}`
`38`	`38`	`if (!$this->okay && $this->forApi) {`
`39`		`- throw new Exception($this->implodedMessages());`
	`39`	`+ throw new \Exception($this->implodedMessages());`
`40`	`40`	`}`
`41`	`41`	`if ($this->okay) {`
`42`		`- error_log($this->implodedMessages());`
`43`	`42`	`return $this->body;`
`44`	`43`	`}`
	`44`	`+ error_log($this->implodedMessages());`
`45`	`45`	`return false;`
`46`	`46`	`}`
`47`	`47`	`}`