Skip to content

Commit 466df41

Browse files
alan-agius4kara
alan-agius4
authored and
kara
committed
test: update payload sizes after TS 3.9 update (angular#36989)
With this changer we update the CLI size-tracking changes for uncompressed main-es2015 file. This file is larger due to new emitted shape of ES2015 classes in TypeScript 3.9, which are now wrapped in IIFE. PR Close angular#36989
1 parent 4e1b5e4 commit 466df41

3 files changed

Lines changed: 13 additions & 11 deletions

File tree

‎goldens/size-tracking/aio-payloads.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
"master": {
1313
"uncompressed": {
1414
"runtime-es2015": 2987,
15-
"main-es2015": 454179,
16-
"polyfills-es2015": 52195
15+
"main-es2015": 453386,
16+
"polyfills-es2015": 52655
1717
}
1818
}
1919
},

‎goldens/size-tracking/integration-payloads.json‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"master": {
44
"uncompressed": {
55
"runtime-es2015": 1485,
6-
"main-es2015": 142794,
6+
"main-es2015": 143350,
77
"polyfills-es2015": 36657
88
}
99
}
@@ -21,7 +21,7 @@
2121
"master": {
2222
"uncompressed": {
2323
"runtime-es2015": 1485,
24-
"main-es2015": 148932,
24+
"main-es2015": 149471,
2525
"polyfills-es2015": 36657
2626
}
2727
}
@@ -30,7 +30,7 @@
3030
"master": {
3131
"uncompressed": {
3232
"runtime-es2015": 1485,
33-
"main-es2015": 138343,
33+
"main-es2015": 138866,
3434
"polyfills-es2015": 37334
3535
}
3636
}
@@ -39,7 +39,7 @@
3939
"master": {
4040
"uncompressed": {
4141
"runtime-es2015": 2289,
42-
"main-es2015": 247761,
42+
"main-es2015": 248455,
4343
"polyfills-es2015": 36657,
4444
"5-es2015": 751
4545
}
@@ -49,7 +49,7 @@
4949
"master": {
5050
"uncompressed": {
5151
"runtime-es2015": 2289,
52-
"main-es2015": 222907,
52+
"main-es2015": 223063,
5353
"polyfills-es2015": 36657,
5454
"5-es2015": 779
5555
}
@@ -60,7 +60,8 @@
6060
"uncompressed": {
6161
"bundle": "TODO(i): temporarily increase the payload size limit from 105779 - this is due to a closure issue related to ESM reexports that still needs to be investigated",
6262
"bundle": "TODO(i): we should define ngDevMode to false in Closure, but --define only works in the global scope.",
63-
"bundle": 169991
63+
"bundle": "TODO(i): (FW-2164) TS 3.9 new class shape seems to have broken Closure in big ways. The size went from 169991 to 252338",
64+
"bundle": 252338
6465
}
6566
}
6667
}

‎integration/BUILD.bazel‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,14 @@ INTEGRATION_TESTS = {
4646
"cli-hello-world-ivy-compat": {"commands": "payload_size_tracking"},
4747
"cli-hello-world-ivy-i18n": {
4848
"commands": "payload_size_tracking",
49-
"tags": ["no-ivy-aot"],
49+
# TODO: (FW-2165) cli-hello-world-ivy-i18n fails on a bundle size check with Ivy bundles
50+
"tags": ["fixme-ivy-aot"],
5051
},
5152
"cli-hello-world-ivy-minimal": {"commands": "payload_size_tracking"},
5253
"cli-hello-world-lazy": {
5354
"commands": "payload_size_tracking",
54-
# TODO: cli-hello-world-lazy fails on a bundle size check with Ivy bundles
55-
"tags": ["no-ivy-aot"],
55+
# TODO: (FW-2165) cli-hello-world-lazy fails on a bundle size check with Ivy bundles
56+
"tags": ["fixme-ivy-aot"],
5657
},
5758
"cli-hello-world-lazy-rollup": {"commands": "payload_size_tracking"},
5859
"dynamic-compiler": {"tags": ["no-ivy-aot"]},

0 commit comments

Comments
 (0)