When baseUri is null or undefined throw error on app.bind() (#24)

TheWillG · ParallelTask · commit d70e8a28af23 · 2018-08-04T22:08:19.000+05:30
diff --git a/src/api/dino.ts b/src/api/dino.ts
@@ -112,11 +112,13 @@ export class Dino implements IDino {
     // since container is already created and bound to express instance
     /**
      * Binds the dino instance to express app
-     * @Throws Error(Errors.routerNotRegistered) 
+     * @Throws Error(Errors.routerNotRegistered)
      * @Throws Error(Errors.dinoAlreadyBinded)
+     * @Throws Error(Errors.baseUriInvalid)
      */
     bind(): void {
         if (this.isBinded) throw new Error(Errors.dinoAlreadyBinded);
+        if (DataUtility.isUndefinedOrNull(this.appContainer.baseUri)) throw new Error(Errors.baseUriInvalid);
         if (DataUtility.isUndefinedOrNull(this.appContainer.useRouter)) {
             throw new Error(Errors.routerNotRegistered);
         }
diff --git a/src/modules/constants/errors.ts b/src/modules/constants/errors.ts
@@ -1,4 +1,5 @@
 export const Errors = {
     dinoAlreadyBinded: 'dino.bind(): Already invoked',
-    routerNotRegistered: 'Express router is not registered with dino'
+    routerNotRegistered: 'Express router is not registered with dino',
+    baseUriInvalid: 'Invalid baseUri to mount the dino app'
 };
diff --git a/tests/unit/api/dino.spec.ts b/tests/unit/api/dino.spec.ts
@@ -20,7 +20,7 @@ describe('api.dino.spec', () => {
         app.registerController(Boolean);
         expect(obj.controllers[0]).toBe(Function);
         expect(obj.controllers[1]).toBe(Boolean);
-        // Following expects are common for most of the tests, 
+        // Following expects are common for most of the tests,
         // should not be deleted easily
         expect(express).toEqual({ expressInstance: true });
         expect(obj.baseUri).toBe('/test');
@@ -137,4 +137,22 @@ describe('api.dino.spec', () => {
         app.bind();
         expect(invoked).toBeTruthy();
     });
+    it('bind.throws_error_when_null_baseUri_provided', () => {
+        let obj: IAppContainer = {} as IAppContainer;
+        obj.useRouter = () => null;
+        obj.build = () => null;
+        spyOn(AppContainer, 'create').and.callFake(() => obj);
+        let app = new Dino({ expressInstance: true } as any, null);
+        expect(() => app.bind())
+            .toThrow(new Error(Errors.baseUriInvalid));
+    });
+    it('bind.throws_error_when_undefined_baseUri_provided', () => {
+        let obj: IAppContainer = {} as IAppContainer;
+        obj.useRouter = () => null;
+        obj.build = () => null;
+        spyOn(AppContainer, 'create').and.callFake(() => obj);
+        let app = new Dino({ expressInstance: true } as any, undefined);
+        expect(() => app.bind())
+            .toThrow(new Error(Errors.baseUriInvalid));
+    });
 });
