Remove git stash from pre-commit hook

olim7t · olim7t · commit fe287e4b4be6 · 2017-04-26T09:04:01.000-07:00
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -112,4 +112,9 @@ ln -s ../../pre-commit.sh .git/hooks/pre-commit
 ```
 
 This will only allow commits if the tests pass. It is also a good reminder to keep the test suite
-short. 
+short.
+
+Note: the tests run on the current state of the working directory. I tried to add a `git stash` in
+the script to only test what's actually being committed, but I couldn't get it to run reliably
+(it's still in there but commented). Keep this in mind when you commit, and don't forget to re-add
+the changes if the first attempt failed and you fixed the tests.
diff --git a/pre-commit.sh b/pre-commit.sh
@@ -1,15 +1,15 @@
 #!/usr/bin/env bash
 
-STASH_NAME="pre-commit-$(date +%s)"
-git stash save --keep-index $STASH_NAME
+# STASH_NAME="pre-commit-$(date +%s)"
+# git stash save --keep-index $STASH_NAME
 
 mvn clean test
 RESULT=$?
 
-STASHES=$(git stash list)
-if [[ $STASHES == *$STASH_NAME* ]]; then
-  git stash pop
-fi
+# STASHES=$(git stash list)
+# if [[ $STASHES == *$STASH_NAME* ]]; then
+#   git stash pop
+# fi
 
 [ $RESULT -ne 0 ] && exit 1
 exit 0
