Skip to content
This repository was archived by the owner on Jun 10, 2019. It is now read-only.
This repository was archived by the owner on Jun 10, 2019. It is now read-only.

Create slack invite page #304

Closed
Closed

Description

@rickr

Feature

Why is this feature being added?

Once discourse is up and running we can open up slack to be a self serve invite.

What should your feature do?

Create a new page (something like /profile/slack) where a user can invite themselves to the slack team. This page should be protected.

When the user clicks a button send a POST request (with no payload) to the endpoint defined in OperationCode/operationcode_backend#102. If successful render a page that informs the user to check their email for a slack invite and some instructions on downloading the app.

Stretch goal: It would be cool to show how many users are in slack on the page.

This change should either not be merged or be shipped dark until OperationCode/operationcode_backend#102 has been deployed

Activity

  1. added this to the Discourse Integration milestone on Jul 19, 2017
  2. self-assigned this
    on Jul 20, 2017
  3. sethbergman commented on Jul 20, 2017

    @sethbergman
    Member

    I have an app that allows the user to enter their email, and then they're invited to the team Slack channel. I have it in it's own repo, but can make a new one for OPC if you think that's a good idea.

    What it requires is an admin API Slack token, and there's an optional invite token available.

  4. rickr commented on Jul 20, 2017

    @rickr
    ContributorAuthor

    I don't think there's a need for a whole app. Thinking about this a bit more I think we can use our current inviter on the backend and just expose it via an API. I've updated the ticket to reflect this change.

  5. sethbergman commented on Jul 20, 2017

    @sethbergman
    Member
  6. rickr commented on Jul 20, 2017

    @rickr
    ContributorAuthor

    While this repo does allow users to sign up for our slack I think it's a bit heavy weight. To implement this we would have to stand up another server, provision a new hostname (and TLS cert), and manage the config. Since the config file contains secrets we'd have to host this in a private repo which goes against the org as a whole. We would also probably want to brand that page (or at least add a logo). This also doesn't meet the requirement of the invite being protected behind an operationcode.org account. If we needed this resolved yesterday this would be a good solution though.

    Since we've already got a backend job that we're currently using I think it's easier to expose that job via the API and creating a new scene here in the front end to explain what slack is and how to use it with a button that will make a call to that new API.

  7. sethbergman commented on Jul 21, 2017

    @sethbergman
    Member

    If you create a CNAME in your DNS, I can use CloudFlare for an SSL and lend my server space (where it's currently hosted) to you until you get your signup flow with the backend in place. If it's not going to take several days/ weeks to implement a frontend scene with the backend API, not to mention whatever you're doing with discourse, then I'd recommend a simple solution. Once a user is signed in on your site, give them a button on their profile page that when clicked, redirects to your CNAME (the slack inviter page) so they can get into your Slack channel. I thinks it's important to sometimes get something shipped, then iterate to make it perfect. If every PM demanded perfection before a release, then their product would fail and they would run out of money. It's just my opinion, and I can agree with your methods if they will produce a working solution quickly.

    It's also important to mark your estimates on these tickets, because I have no idea how long it's going to take to resolve to completion without the estimates. The branding concern can easily be taken care of if needed. I just want to know how I can best help, and where my efforts are needed. Preferably before I solve the problem, not after.

  8. removed their assignment
    on Jul 21, 2017
  9. kylemh commented on Oct 1, 2017

    @kylemh
    Member

    I'm in favor of closing this since user's currently receive an invite to the Slack team. Thoughts?

  10. hollomancer commented on Oct 13, 2017

    @hollomancer
    Member

    I agree that this is not critical right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions