Activity

1. hollomancer

   added

   Type: Bug

   Priority: Low

   good first issue

   on Aug 3, 2018
2. Jacfem commented on Aug 3, 2018

   

   Jacfem

   on Aug 3, 2018

   Contributor

   More actions

   @hollomancer Looking to get involved in the repo, I can take this one!
3. kylemh commented on Aug 3, 2018

   

   kylemh

   on Aug 3, 2018

   Member

   More actions

   @Jacfem - I've assigned myself as a placeholder for your work. Feel free to DM me on Slack if you'd like some help 😄
4. kylemh

   self-assigned this

   on Aug 3, 2018
5. Jacfem commented on Aug 3, 2018

   

   Jacfem

   on Aug 3, 2018

   Contributor

   More actions

   @kylemh Thanks! My one question is what we still want to be the anchor tag - Could you let me know which of these two options?

   1:
   

   2:
   
6. kylemh commented on Aug 3, 2018

   

   kylemh

   on Aug 3, 2018

   Member

   More actions

   Great question. I think I’d prefer option #2

   👍React with 👍1Reacted by Jaclyn Feminella
7. Jacfem commented on Aug 3, 2018

   

   Jacfem

   on Aug 3, 2018

   Contributor

   More actions

   @kylemh Before I open a PR, I noticed in my pushed branch a much larger diff than what I actually changed - it seems there are some pre-push linting hooks that are auto-formatting the file I touched - I didn't see anything about that in the Contributing doc, so is that expected and/or good?

   Thank you for your help!
8. kylemh commented on Aug 4, 2018

   

   kylemh

   on Aug 4, 2018

   Member

   More actions

   Yup yup!

   "lint-staged": {
       "*.{js,json}": ["prettier-eslint --write", "git add"],
       "*.css": ["stylelint --fix", "git add"]
     }
   

   Any files you've changed will get linted in their entirety.

   We should probably run a repo-wide format, but we haven't. Feel free to PR 👍
9. Jacfem commented on Aug 4, 2018

   

   Jacfem

   on Aug 4, 2018

   Contributor

   More actions

   @kylemh sweet, thanks for the clarification! PR here

   🎉React with 🎉1Reacted by Kyle Holmberg
10. kylemh

    closed this as completedin #1020on Aug 4, 2018