Skip to content

Commit b8d3c84

Browse files
author
Ralf W. Grosse-Kunstleve
committed
macro names changed to be more self-documenting
[SVN r15172]
1 parent 9d52087 commit b8d3c84

2 files changed

Lines changed: 15 additions & 11 deletions

File tree

include/boost/python/detail/defaults_gen.hpp

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ struct func_stubs_base {};
224224
//
225225
// There are two versions:
226226
//
227-
// 1. BOOST_PYTHON_FUNCTION_GENERATOR for free functions
228-
// 2. BOOST_PYTHON_MEM_FUN_GENERATOR for member functions.
227+
// 1. BOOST_PYTHON_FUNCTION_OVERLOADS for free functions
228+
// 2. BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS for member functions.
229229
//
230230
// For instance, given a function:
231231
//
@@ -237,7 +237,7 @@ struct func_stubs_base {};
237237
//
238238
// The macro invocation:
239239
//
240-
// BOOST_PYTHON_FUNCTION_GENERATOR(foo_stubs, foo, 1, 4)
240+
// BOOST_PYTHON_FUNCTION_OVERLOADS(foo_stubs, foo, 1, 4)
241241
//
242242
// Generates this code:
243243
//
@@ -284,7 +284,7 @@ struct func_stubs_base {};
284284
// for the return type (void) and the lack of the return keyword.
285285
//
286286
///////////////////////////////////////////////////////////////////////////////
287-
#define BOOST_PYTHON_FUNCTION_GENERATOR(GENERATOR_NAME, FNAME, MIN_ARGS, MAX_ARGS)\
287+
#define BOOST_PYTHON_FUNCTION_OVERLOADS(GENERATOR_NAME, FNAME, MIN_ARGS, MAX_ARGS)\
288288
BPL_IMPL_GEN_FUNCTION_STUB \
289289
( \
290290
FNAME, \
@@ -293,7 +293,7 @@ struct func_stubs_base {};
293293
BOOST_PP_SUB(MAX_ARGS, MIN_ARGS) \
294294
) \
295295

296-
#define BOOST_PYTHON_MEM_FUN_GENERATOR(GENERATOR_NAME, FNAME, MIN_ARGS, MAX_ARGS)\
296+
#define BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(GENERATOR_NAME, FNAME, MIN_ARGS, MAX_ARGS)\
297297
BPL_IMPL_GEN_MEM_FUNCTION_STUB \
298298
( \
299299
FNAME, \
@@ -302,6 +302,10 @@ struct func_stubs_base {};
302302
BOOST_PP_SUB(MAX_ARGS, MIN_ARGS) \
303303
) \
304304

305+
// deprecated macro names (to be removed)
306+
#define BOOST_PYTHON_FUNCTION_GENERATOR BOOST_PYTHON_FUNCTION_OVERLOADS
307+
#define BOOST_PYTHON_MEM_FUN_GENERATOR BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS
308+
305309
///////////////////////////////////////////////////////////////////////////////
306310
#endif // DEFAULTS_GEN_JDG20020807_HPP
307311

test/defaults.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ bar(int a)
4949
return format % make_tuple(a, 'D', "default", 0.0);
5050
}
5151

52-
BOOST_PYTHON_FUNCTION_GENERATOR(bar_stubs, bar, 1, 4)
52+
BOOST_PYTHON_FUNCTION_OVERLOADS(bar_stubs, bar, 1, 4)
5353

5454
///////////////////////////////////////////////////////////////////////////////
5555
//
@@ -62,7 +62,7 @@ foo(int a, char b = 'D', std::string c = "default", double d = 0.0)
6262
return format % make_tuple(a, b, c, d);
6363
}
6464

65-
BOOST_PYTHON_FUNCTION_GENERATOR(foo_stubs, foo, 1, 4)
65+
BOOST_PYTHON_FUNCTION_OVERLOADS(foo_stubs, foo, 1, 4)
6666

6767
///////////////////////////////////////////////////////////////////////////////
6868
//
@@ -117,10 +117,10 @@ struct X {
117117
object state;
118118
};
119119

120-
BOOST_PYTHON_MEM_FUN_GENERATOR(X_bar_stubs, bar, 1, 4)
121-
BOOST_PYTHON_MEM_FUN_GENERATOR(X_bar2_stubs, bar2, 0, 4) // tests zero arg member function
122-
BOOST_PYTHON_MEM_FUN_GENERATOR(X_foo_2_stubs, foo, 1, 2)
123-
BOOST_PYTHON_MEM_FUN_GENERATOR(X_foo_3_stubs, foo, 2, 3)
120+
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(X_bar_stubs, bar, 1, 4)
121+
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(X_bar2_stubs, bar2, 0, 4) // tests zero arg member function
122+
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(X_foo_2_stubs, foo, 1, 2)
123+
BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(X_foo_3_stubs, foo, 2, 3)
124124

125125
///////////////////////////////////////////////////////////////////////////////
126126

0 commit comments

Comments
 (0)