Skip to content

Adds note about gson map decoding to README#451

Merged
spencergibb merged 1 commit into
masterfrom
gson-map
Aug 29, 2016
Merged

Adds note about gson map decoding to README#451
spencergibb merged 1 commit into
masterfrom
gson-map

Conversation

@codefromthecrypt
Copy link
Copy Markdown

@codefromthecrypt
Copy link
Copy Markdown
Author

while I don't care enough to do more than document this, since there's a workaround. If someone wants to shade the internal classes used in DoubleToIntMapTypeAdapter, or redo it portably without use of internal classes, knock yourself out! I'll help review

@spencergibb spencergibb merged commit 7ccc965 into master Aug 29, 2016
@raulk
Copy link
Copy Markdown
Contributor

raulk commented Aug 29, 2016

There is a less invasive approach. If someone really does want to use an internal class of Gson which the bundle doesn't expose, they can deploy an OSGi fragment that attaches to the Gson bundle and exports the additional (internal) package from it.

@codefromthecrypt
Copy link
Copy Markdown
Author

I went ahead and found a solution to the issue as I can't afford the time
to continually discuss the two lines involved

#452

On Mon, Aug 29, 2016 at 7:55 PM, Raúl Kripalani notifications@github.com
wrote:

There is a less invasive approach. If someone really does want to use an
internal class of Gson which the bundle doesn't expose, they can deploy an OSGi
fragment
http://docs.spring.io/osgi/docs/current/reference/html/appendix-tips.html
that attaches to the Gson bundle and exports the additional (internal)
package from it.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#451 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD613CF7XPfv4AcNABri7dbfx137VFeks5qksiggaJpZM4JvEdq
.

@velo velo deleted the gson-map branch May 5, 2018 22:31
velo pushed a commit that referenced this pull request Oct 7, 2024
velo pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants