Java11client connect timeout (#1307)

gb-klein · Gunther Klein · kdavisk6 · web-flow · commit a235bd90fb3b · 2020-12-22T20:35:17.000-05:00
* Set connect timeout from feign Option on java11 HttpClient

* added a constructor to Http2Client which takes Options argument

Co-authored-by: Gunther Klein &lt;gunther.klein@thepaymail.com&gt;
Co-authored-by: Kevin Davis &lt;kdavisk6@gmail.com&gt;
diff --git a/java11/src/main/java/feign/http2client/Http2Client.java b/java11/src/main/java/feign/http2client/Http2Client.java
@@ -44,17 +44,22 @@ public Http2Client() {
     this(HttpClient.newBuilder().followRedirects(Redirect.ALWAYS).version(Version.HTTP_2).build());
   }
 
+  public Http2Client(Options options) {
+    this(newClientBuilder(options).version(Version.HTTP_2).build());
+  }
+
   public Http2Client(HttpClient client) {
     this.client = Util.checkNotNull(client, "HttpClient must not be null");
   }
 
   @Override
   public Response execute(Request request, Options options) throws IOException {
     final HttpRequest httpRequest = newRequestBuilder(request, options).build();
+    HttpClient clientForRequest = getOrCreateClient(options);
 
     HttpResponse<byte[]> httpResponse;
     try {
-      httpResponse = client.send(httpRequest, BodyHandlers.ofByteArray());
+      httpResponse = clientForRequest.send(httpRequest, BodyHandlers.ofByteArray());
     } catch (final InterruptedException e) {
       Thread.currentThread().interrupt();
       throw new IOException("Invalid uri " + request.url(), e);
@@ -75,6 +80,40 @@ public Response execute(Request request, Options options) throws IOException {
     return response;
   }
 
+  private HttpClient getOrCreateClient(Options options) {
+    if (doesClientConfigurationDiffer(options)) {
+      // create a new client from the existing one - but with connectTimeout and followRedirect
+      // settings from options
+      java.net.http.HttpClient.Builder builder =
+          newClientBuilder(options)
+              .sslContext(client.sslContext())
+              .sslParameters(client.sslParameters())
+              .version(client.version());
+      client.authenticator().ifPresent(builder::authenticator);
+      client.cookieHandler().ifPresent(builder::cookieHandler);
+      client.executor().ifPresent(builder::executor);
+      client.proxy().ifPresent(builder::proxy);
+      return builder.build();
+    }
+    return client;
+  }
+
+  private boolean doesClientConfigurationDiffer(Options options) {
+    if ((client.followRedirects() == Redirect.ALWAYS) != options.isFollowRedirects()) {
+      return true;
+    }
+    return client
+        .connectTimeout()
+        .map(timeout -> timeout.toMillis() != options.connectTimeoutMillis())
+        .orElse(true);
+  }
+
+  private static java.net.http.HttpClient.Builder newClientBuilder(Options options) {
+    return HttpClient.newBuilder()
+        .followRedirects(options.isFollowRedirects() ? Redirect.ALWAYS : Redirect.NEVER)
+        .connectTimeout(Duration.ofMillis(options.connectTimeoutMillis()));
+  }
+
   private Builder newRequestBuilder(Request request, Options options) throws IOException {
     URI uri;
     try {
