This repository was archived by the owner on Dec 20, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 20, 2021. It is now read-only.
Bug in TranslateString method #935
Description
Describe the bug
There is a problem with the TranslateString method in the asset manager. When a key exists in another *.tbl. We only get the first appearance. Keys like # + idx have duplicates. So we have no control over which table we get the translation from.
Activity
gravestench commentedon Dec 21, 2020
I'll agree that there are identical keys in multiple tables, but I don't feel that this is an issue. The MPQ's share many files, and the load-order of the MPQ determine's which file is used (this is by blizzard's design).
This is just a hunch, but I think the real issue here is the order in which we load all of the string tables.
@PushUpek Do you have an example of a particular key+string and which possible tables it can come from vs where it should come from?
gucio321 commentedon Dec 21, 2020
see d2game/d2gamescreen/select_hero_class.go:706
gucio321 commentedon Dec 21, 2020
Instead of druid description, we can see some string from battle.net game (sth like "character with name %s already exists in this realm")