fail_function: fix wrong use of fei_attr_remove()

Yang Yingliang · akpm00 · commit d2e85432a2e0 · 2022-09-11T21:55:11.000-07:00
If register_kprobe() fails, the new attr is not added to the list yet, so it should call fei_attr_free() intstead. Link: https://lkml.kernel.org/r/20220826073337.2085798-3-yangyingliang@huawei.com Fixes: 4b1a29a ("error-injection: Support fault injection framework") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
diff --git a/kernel/fail_function.c b/kernel/fail_function.c
@@ -295,7 +295,7 @@ static ssize_t fei_write(struct file *file, const char __user *buffer,
 
 	ret = register_kprobe(&attr->kp);
 	if (ret) {
-		fei_attr_remove(attr);
+		fei_attr_free(attr);
 		goto out;
 	}
 	fei_debugfs_add_attr(attr);

Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,7 @@ static ssize_t fei_write(struct file file, const char __user buffer,`
`295`	`295`
`296`	`296`	`ret = register_kprobe(&attr->kp);`
`297`	`297`	`if (ret) {`
`298`		`- fei_attr_remove(attr);`
	`298`	`+ fei_attr_free(attr);`
`299`	`299`	`goto out;`
`300`	`300`	`}`
`301`	`301`	`fei_debugfs_add_attr(attr);`