Skip to content
This repository was archived by the owner on Jun 18, 2024. It is now read-only.

Added pooling for ServiceRequestBase#491

Merged
serious6 merged 1 commit into
OfficeDev:masterfrom
SebastianWe:master
Mar 19, 2016
Merged

Added pooling for ServiceRequestBase#491
serious6 merged 1 commit into
OfficeDev:masterfrom
SebastianWe:master

Conversation

@SebastianWe
Copy link
Copy Markdown

@SebastianWe SebastianWe commented Feb 9, 2016

After using the fix #428 to make the ExchangeService thread safe, a developer can run into a "ServiceRequestException: The request failed. Connection is still allocated".

This can be fixed by using the ExchangeServiceBase#httpPoolingClient for requests.
This Pull-Requests provides a simple differentiation between the ExchangeServiceBase#httpClient and ExchangeServiceBase#httpPoolingClient.

@azurecla
Copy link
Copy Markdown

azurecla commented Feb 9, 2016

Hi @SebastianWe, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@SebastianWe SebastianWe mentioned this pull request Feb 9, 2016
Closed
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 9, 2016

Current coverage is 10.42%

Merging #491 into master will not affect coverage as of e6ea8ea

@@            master    #491   diff @@
======================================
  Files          550     550       
  Stmts        20432   20435     +3
  Branches      2625    2626     +1
  Methods          0       0       
======================================
  Hit           2131    2131       
  Partial        153     153       
- Missed       18148   18151     +3

Review entire Coverage Diff as of e6ea8ea

Powered by Codecov. Updated on successful CI builds.

@serious6 serious6 added this to the 2.1 milestone Mar 19, 2016
serious6 added a commit that referenced this pull request Mar 19, 2016
@serious6
Merge pull request #491 from SebastianWe/master
61b3fe1 
Added pooling for ServiceRequestBase
@serious6 serious6 merged commit 61b3fe1 into OfficeDev:master Mar 19, 2016
@serious6
Copy link
Copy Markdown
Member

serious6 commented Mar 19, 2016

@SebastianWe thanks for your contribution

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@SebastianWe @azurecla @codecov-io @serious6