Address janvorli's feedback comments

am11 · am11 · commit 577f07f6b164 · 2019-02-25T04:41:04.000-08:00
Commit migrated from dotnet/coreclr@805c8b2
diff --git a/src/coreclr/src/debug/createdump/datatarget.cpp b/src/coreclr/src/debug/createdump/datatarget.cpp
@@ -150,8 +150,8 @@ DumpDataTarget::ReadVirtual(
     /* [optional][out] */ ULONG32 *done)
 {
     assert(m_fd != -1);
-    size_t read = pread64(m_fd, buffer, size, (off64_t)(ULONG_PTR)address);
-    if (read == (size_t)-1)
+    ssize_t read = pread64(m_fd, buffer, size, (off64_t)(ULONG_PTR)address);
+    if (read == -1)
     {
         *done = 0;
         return E_FAIL;
diff --git a/src/coreclr/tests/src/Interop/PInvoke/Decimal/PInvoke/DecNative.cpp b/src/coreclr/tests/src/Interop/PInvoke/Decimal/PInvoke/DecNative.cpp
@@ -10,7 +10,7 @@ DECIMAL g_DECIMAL_MaxValue = { 0, {{ 0, 0 }}, static_cast<int>(0xffffffff), {{st
 DECIMAL g_DECIMAL_MinValue  = { 0, {{ 0, DECIMAL_NEG }}, static_cast<int>(0xffffffff), {{static_cast<int>(0xffffffff), static_cast<int>(0xffffffff)}} };
 DECIMAL g_DECIMAL_Zero = { 0 };
 
-CY g_CY_MaxValue = { { static_cast<int>(0xffffffff), static_cast<int>(0x7fffffff) } };
+CY g_CY_MaxValue = { { static_cast<int>(0xffffffff), 0x7fffffff} };
 CY g_CY_MinValue = { { (LONG)0x00000000, (LONG)0x80000000 } };
 CY g_CY_Zero = { { 0 } };
 
diff --git a/src/coreclr/tests/src/Interop/PInvoke/Decimal/ReversePInvoke/RevNative.cpp b/src/coreclr/tests/src/Interop/PInvoke/Decimal/ReversePInvoke/RevNative.cpp
@@ -10,7 +10,7 @@ DECIMAL g_DECIMAL_MaxValue = { 0, {{ 0, 0 }}, static_cast<int>(0xffffffff), {{st
 DECIMAL g_DECIMAL_MinValue  = { 0, {{ 0, DECIMAL_NEG }}, static_cast<int>(0xffffffff), {{static_cast<int>(0xffffffff), static_cast<int>(0xffffffff) }}};
 DECIMAL g_DECIMAL_Zero = { 0 };
 
-CY g_CY_MaxValue = { {static_cast<int>(0xffffffff), static_cast<int>(0x7fffffff)} };
+CY g_CY_MaxValue = { {static_cast<int>(0xffffffff), 0x7fffffff} };
 CY g_CY_MinValue = { {(LONG)0x00000000, (LONG)0x80000000} };
 CY g_CY_Zero = { {0} };
 

Original file line number	Diff line number	Diff line change
`@@ -150,8 +150,8 @@ DumpDataTarget::ReadVirtual(`
`150`	`150`	`/* [optional][out] / ULONG32 done)`
`151`	`151`	`{`
`152`	`152`	`assert(m_fd != -1);`
`153`		`- size_t read = pread64(m_fd, buffer, size, (off64_t)(ULONG_PTR)address);`
`154`		`- if (read == (size_t)-1)`
	`153`	`+ ssize_t read = pread64(m_fd, buffer, size, (off64_t)(ULONG_PTR)address);`
	`154`	`+ if (read == -1)`
`155`	`155`	`{`
`156`	`156`	`*done = 0;`
`157`	`157`	`return E_FAIL;`