[WIP] Try fixing failing IpPacketInformationTest (dotnet/corefx#41411)

eiriktsarpalis · web-flow · commit 0628438acb2d · 2019-09-30T16:32:12.000-07:00
Try fixing failing IpPacketInformationTest Commit migrated from dotnet/corefx@969ce66
diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/IPPacketInformationTest.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/IPPacketInformationTest.cs
@@ -51,7 +51,7 @@ public void GetHashCode_NonDefaultValue_Succes()
 
         private IPPacketInformation GetNonDefaultIPPacketInformation()
         {
-            const int ReceiveTimeout = 5000;
+            const int ReceiveTimeout = 10000;
 
             using (var receiver = new Socket(AddressFamily.InterNetwork, SocketType.Dgram, ProtocolType.Udp))
             using (var sender = new Socket(AddressFamily.InterNetwork, SocketType.Dgram, ProtocolType.Udp))
@@ -68,15 +68,15 @@ private IPPacketInformation GetNonDefaultIPPacketInformation()
                 receiveArgs.SetBuffer(new byte[1], 0, 1);
                 receiveArgs.Completed += (_, args) => ((ManualResetEvent)args.UserToken).Set();
 
-                Assert.True(receiver.ReceiveMessageFromAsync(receiveArgs));
+                Assert.True(receiver.ReceiveMessageFromAsync(receiveArgs), "receiver.ReceiveMessageFromAsync");
 
                 // Send a few packets, in case they aren't delivered reliably.
                 for (int i = 0; i < TestSettings.UDPRedundancy; i++)
                 {
                     sender.SendTo(new byte[1], new IPEndPoint(IPAddress.Loopback, port));
                 }
 
-                Assert.True(waitHandle.WaitOne(ReceiveTimeout));
+                Assert.True(waitHandle.WaitOne(ReceiveTimeout), "waitHandle.WaitOne");
 
                 return receiveArgs.ReceiveMessageFromPacketInfo;
             }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public void GetHashCode_NonDefaultValue_Succes()`
`51`	`51`
`52`	`52`	`private IPPacketInformation GetNonDefaultIPPacketInformation()`
`53`	`53`	`{`
`54`		`- const int ReceiveTimeout = 5000;`
	`54`	`+ const int ReceiveTimeout = 10000;`
`55`	`55`
`56`	`56`	`using (var receiver = new Socket(AddressFamily.InterNetwork, SocketType.Dgram, ProtocolType.Udp))`
`57`	`57`	`using (var sender = new Socket(AddressFamily.InterNetwork, SocketType.Dgram, ProtocolType.Udp))`
`@@ -68,15 +68,15 @@ private IPPacketInformation GetNonDefaultIPPacketInformation()`
`68`	`68`	`receiveArgs.SetBuffer(new byte[1], 0, 1);`
`69`	`69`	`receiveArgs.Completed += (_, args) => ((ManualResetEvent)args.UserToken).Set();`
`70`	`70`
`71`		`- Assert.True(receiver.ReceiveMessageFromAsync(receiveArgs));`
	`71`	`+ Assert.True(receiver.ReceiveMessageFromAsync(receiveArgs), "receiver.ReceiveMessageFromAsync");`
`72`	`72`
`73`	`73`	`// Send a few packets, in case they aren't delivered reliably.`
`74`	`74`	`for (int i = 0; i < TestSettings.UDPRedundancy; i++)`
`75`	`75`	`{`
`76`	`76`	`sender.SendTo(new byte[1], new IPEndPoint(IPAddress.Loopback, port));`
`77`	`77`	`}`
`78`	`78`
`79`		`- Assert.True(waitHandle.WaitOne(ReceiveTimeout));`
	`79`	`+ Assert.True(waitHandle.WaitOne(ReceiveTimeout), "waitHandle.WaitOne");`
`80`	`80`
`81`	`81`	`return receiveArgs.ReceiveMessageFromPacketInfo;`
`82`	`82`	`}`