fixed incorrect parameter logging when parameters were added from user claims as string array (roles, permissions, etc).

vbilopav · vbilopav · commit c00700fe4ecb · 2025-11-16T12:28:41.000+01:00
diff --git a/NpgsqlRest/ParameterParser.cs b/NpgsqlRest/ParameterParser.cs
@@ -416,15 +416,28 @@ internal static string FormatParam(object value, TypeDescriptor descriptor)
         {
             return Consts.Null;
         }
-        // TODO fix this: fix array parameter logging: e.g. -- $6 text[] = 'System.Collections.Generic.List`1[System.String]'
-        if (descriptor.IsArray && value is IList<object> list)
+        if (descriptor.IsArray)
         {
-            var d = descriptor;
-            if (descriptor is { IsNumeric: false, IsBoolean: false })
+            if (value is IList<object> objectList)
             {
-                return string.Concat("{", string.Join(",", list.Select(x => string.Concat("'", Format(x, d), "'"))), "}");
+                var d = descriptor;
+                if (descriptor is { IsNumeric: false, IsBoolean: false })
+                {
+                    return string.Concat("{", string.Join(",", objectList.Select(x => string.Concat("'", Format(x, d), "'"))),
+                        "}");
+                }
+                return string.Concat("{", string.Join(",", objectList.Select(x => Format(x, d))), "}");
+            }
+            if (value is IList<string> stringList)
+            {
+                var d = descriptor;
+                if (descriptor is { IsNumeric: false, IsBoolean: false })
+                {
+                    return string.Concat("{", string.Join(",", stringList.Select(x => string.Concat("'", Format(x, d), "'"))),
+                        "}");
+                }
+                return string.Concat("{", string.Join(",", stringList.Select(x => Format(x, d))), "}");
             }
-            return string.Concat("{", string.Join(",", list.Select(x => Format(x, d))), "}");
         }
         if (descriptor is { IsNumeric: false, IsBoolean: false })
         {
diff --git a/changelog.md b/changelog.md
@@ -29,8 +29,6 @@ private static readonly string[] InfoEventsStreamingScopeKey = [
 
 - TODO fix claims to parameters or user context mapping - if empty string is passed, use null (make it optional with default true)
 
-- TODO fix array parameter logging: e.g. -- $6 text[] = 'System.Collections.Generic.List`1[System.String]'
-
 ## Version [3.0.0](https://github.com/NpgsqlRest/NpgsqlRest/tree/3.0.0) (date is TBD)
 
 [Full Changelog](https://github.com/NpgsqlRest/NpgsqlRest/compare/2.36.0...2.36.1)
@@ -428,6 +426,7 @@ rate_limiter [ name ]
 - Refactoring: moved some files around to better structure the project.
 - Removed unnecessary type casting when routine source returns set with embedded composite type.
 - Fix: fixed incorrect handling of types with modifier (e.g. varchar(100), numeric(10,2), etc). This causes type with modifiers to be serialized as incorrect type.
+- Fix: fixed incorrect parameter logging when parameters were added from user claims as string array (roles, permissions, etc).
 
 #### Login Endpoint Changes
 

Original file line number	Diff line number	Diff line change
`@@ -416,15 +416,28 @@ internal static string FormatParam(object value, TypeDescriptor descriptor)`
`416`	`416`	`{`
`417`	`417`	`return Consts.Null;`
`418`	`418`	`}`
`419`		- // TODO fix this: fix array parameter logging: e.g. -- $6 text[] = 'System.Collections.Generic.List`1[System.String]'
`420`		`- if (descriptor.IsArray && value is IList<object> list)`
	`419`	`+ if (descriptor.IsArray)`
`421`	`420`	`{`
`422`		`- var d = descriptor;`
`423`		`- if (descriptor is { IsNumeric: false, IsBoolean: false })`
	`421`	`+ if (value is IList<object> objectList)`
`424`	`422`	`{`
`425`		`- return string.Concat("{", string.Join(",", list.Select(x => string.Concat("'", Format(x, d), "'"))), "}");`
	`423`	`+ var d = descriptor;`
	`424`	`+ if (descriptor is { IsNumeric: false, IsBoolean: false })`
	`425`	`+ {`
	`426`	`+ return string.Concat("{", string.Join(",", objectList.Select(x => string.Concat("'", Format(x, d), "'"))),`
	`427`	`+ "}");`
	`428`	`+ }`
	`429`	`+ return string.Concat("{", string.Join(",", objectList.Select(x => Format(x, d))), "}");`
	`430`	`+ }`
	`431`	`+ if (value is IList<string> stringList)`
	`432`	`+ {`
	`433`	`+ var d = descriptor;`
	`434`	`+ if (descriptor is { IsNumeric: false, IsBoolean: false })`
	`435`	`+ {`
	`436`	`+ return string.Concat("{", string.Join(",", stringList.Select(x => string.Concat("'", Format(x, d), "'"))),`
	`437`	`+ "}");`
	`438`	`+ }`
	`439`	`+ return string.Concat("{", string.Join(",", stringList.Select(x => Format(x, d))), "}");`
`426`	`440`	`}`
`427`		`- return string.Concat("{", string.Join(",", list.Select(x => Format(x, d))), "}");`
`428`	`441`	`}`
`429`	`442`	`if (descriptor is { IsNumeric: false, IsBoolean: false })`
`430`	`443`	`{`