Minor fix of index variable in inserttable method

Cito · Cito · commit f96cee91cfe5 · 2020-06-21T16:39:23.000+02:00
diff --git a/pgconn.c b/pgconn.c
@@ -771,8 +771,8 @@ conn_inserttable(connObject *self, PyObject *args)
     if (columns) {
         /* adds a string like f" ({','.join(columns)})" */
         bufpt += sprintf(bufpt, " (");
-        for (int i = 0; i < n; ++i) {
-            PyObject *obj = getcolumn(columns, i);
+        for (j = 0; j < n; ++j) {
+            PyObject *obj = getcolumn(columns, j);
             ssize_t slen;
             char *col;
 
@@ -790,7 +790,7 @@ conn_inserttable(connObject *self, PyObject *args)
                     "The third argument must contain only strings");
             }
             col = PQescapeIdentifier(self->cnx, col, (size_t) slen);
-            bufpt += sprintf(bufpt, "%s%s", col, i == n - 1 ? ")" : ",");
+            bufpt += sprintf(bufpt, "%s%s", col, j == n - 1 ? ")" : ",");
             PQfreemem(col);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -771,8 +771,8 @@ conn_inserttable(connObject self, PyObject args)`
`771`	`771`	`if (columns) {`
`772`	`772`	`/* adds a string like f" ({','.join(columns)})" */`
`773`	`773`	`bufpt += sprintf(bufpt, " (");`
`774`		`- for (int i = 0; i < n; ++i) {`
`775`		`- PyObject *obj = getcolumn(columns, i);`
	`774`	`+ for (j = 0; j < n; ++j) {`
	`775`	`+ PyObject *obj = getcolumn(columns, j);`
`776`	`776`	`ssize_t slen;`
`777`	`777`	`char *col;`
`778`	`778`
`@@ -790,7 +790,7 @@ conn_inserttable(connObject self, PyObject args)`
`790`	`790`	`"The third argument must contain only strings");`
`791`	`791`	`}`
`792`	`792`	`col = PQescapeIdentifier(self->cnx, col, (size_t) slen);`
`793`		`- bufpt += sprintf(bufpt, "%s%s", col, i == n - 1 ? ")" : ",");`
	`793`	`+ bufpt += sprintf(bufpt, "%s%s", col, j == n - 1 ? ")" : ",");`
`794`	`794`	`PQfreemem(col);`
`795`	`795`	`}`
`796`	`796`	`}`