https-proxy-agent: add support for proxy "headers"

TooTallNate · TooTallNate · commit f2b10805e338 · 2015-07-15T16:38:05.000-07:00
Inspired from, and closes TooTallNate#5. Thanks @mrgiba!
diff --git a/https-proxy-agent.js b/https-proxy-agent.js
@@ -191,12 +191,16 @@ function connect (req, opts, fn) {
 
   var hostname = opts.host + ':' + opts.port;
   var msg = 'CONNECT ' + hostname + ' HTTP/1.1\r\n';
-  var auth = proxy.auth;
-  if (auth) {
-    msg += 'Proxy-Authorization: Basic ' + new Buffer(auth).toString('base64') + '\r\n';
+
+  var headers = extend({}, proxy.headers);
+  if (proxy.auth) {
+    headers['Proxy-Authorization'] = 'Basic ' + new Buffer(proxy.auth).toString('base64');
   }
-  msg += 'Host: ' + hostname + '\r\n' +
-         'Connection: close\r\n' +
-         '\r\n';
-  socket.write(msg);
+  headers['Host'] = hostname;
+  headers['Connection'] = 'close';
+  Object.keys(headers).forEach(function (name) {
+    msg += name + ': ' + headers[name] + '\r\n';
+  });
+
+  socket.write(msg + '\r\n');
 };
diff --git a/test/test.js b/test/test.js
@@ -223,6 +223,31 @@ describe('HttpsProxyAgent', function () {
         done();
       });
     });
+
+    it('should allow custom proxy "headers"', function (done) {
+      server.once('connect', function (req, socket, head) {
+        assert.equal('CONNECT', req.method);
+        assert.equal('bar', req.headers.foo);
+        socket.destroy();
+        done();
+      });
+
+      var uri = 'http://127.0.0.1:' + serverPort;
+      var proxyOpts = url.parse(uri);
+      proxyOpts.headers = {
+        'Foo': 'bar'
+      };
+      var agent = new HttpsProxyAgent(proxyOpts);
+
+      var opts = {};
+      // `host` and `port` don't really matter since the proxy will reject anyways
+      opts.host = '127.0.0.1';
+      opts.port = 80;
+      opts.agent = agent;
+
+      http.get(opts);
+    });
+
   });
 
   describe('"https" module', function () {
