Skip to content

Commit d42e37b

Browse files
hdeshevhdeshev
committed
Enable TypeScript checks for unused locals and parameters.
1 parent 4c8f33c commit d42e37b

28 files changed

Lines changed: 99 additions & 153 deletions

‎nativescript-angular/animation-driver.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export class NativeScriptAnimationDriver implements AnimationDriver {
1616
return (<View>element).style._getValue(getPropertyByCssName(prop));
1717
}
1818

19-
animate(element: any, startingStyles: AnimationStyles, keyframes: AnimationKeyframe[], duration: number, delay: number, easing: string): AnimationPlayer {
19+
animate(element: any, _startingStyles: AnimationStyles, keyframes: AnimationKeyframe[], duration: number, delay: number, easing: string): AnimationPlayer {
2020
return new NativeScriptAnimationPlayer(element, keyframes, duration, delay, easing);
2121
}
2222
}

‎nativescript-angular/animation-player.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export class NativeScriptAnimationPlayer implements AnimationPlayer {
9898
this._onStart();
9999
this.animation.play(this.target)
100100
.then(() => { this._onFinish(); })
101-
.catch((e) => { });
101+
.catch((_e) => { });
102102
}
103103
}
104104

@@ -126,7 +126,7 @@ export class NativeScriptAnimationPlayer implements AnimationPlayer {
126126
this._onFinish();
127127
}
128128

129-
setPosition(p: any): void {
129+
setPosition(_p: any): void {
130130
throw new Error("AnimationPlayer.setPosition method is not supported!");
131131
}
132132

‎nativescript-angular/collection-facade.ts‎

Lines changed: 0 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -131,66 +131,3 @@ function _flattenArray(source: any[], target: any[]): any[] {
131131
}
132132
return target;
133133
}
134-
135-
export class StringMapWrapper {
136-
static create(): {[k: /*any*/ string]: any} {
137-
// Note: We are not using Object.create(null) here due to
138-
// performance!
139-
// http://jsperf.com/ng2-object-create-null
140-
return {};
141-
}
142-
static contains(map: {[key: string]: any}, key: string): boolean {
143-
return map.hasOwnProperty(key);
144-
}
145-
static get<V>(map: {[key: string]: V}, key: string): V {
146-
return map.hasOwnProperty(key) ? map[key] : undefined;
147-
}
148-
static set<V>(map: {[key: string]: V}, key: string, value: V) { map[key] = value; }
149-
150-
static keys(map: {[key: string]: any}): string[] { return Object.keys(map); }
151-
static values<T>(map: {[key: string]: T}): T[] {
152-
return Object.keys(map).map((k: string): T => map[k]);
153-
}
154-
static isEmpty(map: {[key: string]: any}): boolean {
155-
for (var prop in map) {
156-
return false;
157-
}
158-
return true;
159-
}
160-
static delete (map: {[key: string]: any}, key: string) { delete map[key]; }
161-
static forEach<K, V>(map: {[key: string]: V}, callback: (v: V, K: string) => void) {
162-
for (let k of Object.keys(map)) {
163-
callback(map[k], k);
164-
}
165-
}
166-
167-
static merge<V>(m1: {[key: string]: V}, m2: {[key: string]: V}): {[key: string]: V} {
168-
var m: {[key: string]: V} = {};
169-
170-
for (let k of Object.keys(m1)) {
171-
m[k] = m1[k];
172-
}
173-
174-
for (let k of Object.keys(m2)) {
175-
m[k] = m2[k];
176-
}
177-
178-
return m;
179-
}
180-
181-
static equals<V>(m1: {[key: string]: V}, m2: {[key: string]: V}): boolean {
182-
var k1 = Object.keys(m1);
183-
var k2 = Object.keys(m2);
184-
if (k1.length != k2.length) {
185-
return false;
186-
}
187-
var key: any /** TODO #???? */;
188-
for (var i = 0; i < k1.length; i++) {
189-
key = k1[i];
190-
if (m1[key] !== m2[key]) {
191-
return false;
192-
}
193-
}
194-
return true;
195-
}
196-
}

‎nativescript-angular/common/detached-loader.ts‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,6 @@ import {
44
} from '@angular/core';
55
import * as trace from "trace";
66

7-
type AnyComponentRef = ComponentRef<any>;
8-
interface PendingLoadEntry {
9-
componentType: Type<any>;
10-
resolveCallback: (AnyComponentRef) => void;
11-
}
12-
137
export const CATEGORY = "detached-loader";
148
function log(message: string) {
159
trace.write(message, CATEGORY);

‎nativescript-angular/directives/action-bar.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { registerElement, ViewClassMeta, NgView } from '../element-registry';
77

88
var actionBarMeta: ViewClassMeta = {
99
skipAddToDom: true,
10-
insertChild: (parent: NgView, child: NgView, atIndex: number) => {
10+
insertChild: (parent: NgView, child: NgView, _atIndex: number) => {
1111
const bar = <ActionBar>(<any>parent);
1212
const childView = <any>child;
1313

‎nativescript-angular/directives/dialogs.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export class ModalDialogService {
3939
const resolver: ComponentFactoryResolver = viewContainerRef.injector.get(ComponentFactoryResolver);
4040
const pageFactory: PageFactory = viewContainerRef.injector.get(PAGE_FACTORY);
4141

42-
return new Promise((resolve, reject) => {
42+
return new Promise((resolve) => {
4343
setTimeout(() => ModalDialogService.showDialog(type, options, resolve, viewContainerRef, resolver, parentPage, pageFactory), 10);
4444
});
4545
}

‎nativescript-angular/directives/list-view-comp.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,13 @@ export class ListViewComponent implements DoCheck, OnDestroy, AfterContentInit {
7979
needDiffer = false;
8080
}
8181
if (needDiffer && !this._differ && isListLikeIterable(value)) {
82-
this._differ = this._iterableDiffers.find(this._items).create(this._cdr, (index, item) => { return item; });
82+
this._differ = this._iterableDiffers.find(this._items).create(this._cdr, (_index, item) => { return item; });
8383
}
8484

8585
this.listView.items = this._items;
8686
}
8787

88-
constructor(private _elementRef: ElementRef,
88+
constructor(_elementRef: ElementRef,
8989
private _iterableDiffers: IterableDiffers,
9090
private _cdr: ChangeDetectorRef) {
9191
this.listView = _elementRef.nativeElement;

‎nativescript-angular/directives/tab-view.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import {ElementRef, Directive, Input, TemplateRef, ViewContainerRef} from "@angular/core";
2-
import {TabView, TabViewItem} from "ui/tab-view";
1+
import { ElementRef, Directive, Input, TemplateRef, ViewContainerRef } from "@angular/core";
2+
import { TabView, TabViewItem } from "ui/tab-view";
33
import * as utils from '../common/utils';
4-
import {rendererLog, rendererError} from "../trace";
5-
import {isBlank} from "../lang-facade";
4+
import { rendererLog } from "../trace";
5+
import { isBlank } from "../lang-facade";
66

77
@Directive({
88
selector: 'TabView',
@@ -24,7 +24,7 @@ export class TabViewDirective {
2424
}
2525
}
2626

27-
constructor(private element: ElementRef) {
27+
constructor(element: ElementRef) {
2828
this.tabView = element.nativeElement;
2929
}
3030

‎nativescript-angular/dom-adapter.ts‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { ElementSchemaRegistry } from '@angular/compiler';
2-
import { Sanitizer, SchemaMetadata } from '@angular/core';
2+
import { SchemaMetadata } from '@angular/core';
33
import { Parse5DomAdapter } from "./parse5_adapter";
44
import { setRootDomAdapter } from './private_import_platform-browser';
5-
import { rendererLog, rendererError } from "./trace";
5+
import { rendererLog } from "./trace";
66
import { print } from "./lang-facade";
77

88
export enum SecurityContext {
@@ -15,11 +15,11 @@ export enum SecurityContext {
1515
}
1616

1717
export class NativeScriptElementSchemaRegistry extends ElementSchemaRegistry {
18-
hasProperty(tagName: string, propName: string): boolean {
18+
hasProperty(_tagName: string, _propName: string): boolean {
1919
return true;
2020
}
2121

22-
hasElement(tagName: string, schemaMetas: SchemaMetadata[]): boolean {
22+
hasElement(_tagName: string, _schemaMetas: SchemaMetadata[]): boolean {
2323
return true;
2424
}
2525

@@ -32,15 +32,15 @@ export class NativeScriptElementSchemaRegistry extends ElementSchemaRegistry {
3232
return 'ng-component';
3333
}
3434

35-
securityContext(tagName: string, propName: string): any {
35+
securityContext(_tagName: string, _propName: string): any {
3636
return SecurityContext.NONE;
3737
}
3838

39-
validateProperty(name: string): { error: boolean, msg?: string } {
39+
validateProperty(_name: string): { error: boolean, msg?: string } {
4040
return { error: false };
4141
}
4242

43-
validateAttribute(name: string): { error: boolean, msg?: string } {
43+
validateAttribute(_name: string): { error: boolean, msg?: string } {
4444
return { error: false };
4545
}
4646

@@ -52,7 +52,7 @@ export class NativeScriptElementSchemaRegistry extends ElementSchemaRegistry {
5252
return propName;
5353
}
5454

55-
normalizeAnimationStyleValue(camelCaseProp: string, userProvidedProp: string, val: string | number):
55+
normalizeAnimationStyleValue(_camelCaseProp: string, _userProvidedProp: string, val: string | number):
5656
{ error: string, value: string } {
5757
return { error: null, value: val.toString() };
5858
}
@@ -64,7 +64,7 @@ export class NativeScriptDomAdapter extends Parse5DomAdapter {
6464
setRootDomAdapter(new NativeScriptDomAdapter());
6565
}
6666

67-
hasProperty(element, name: string) {
67+
hasProperty(_element: any, _name: string) {
6868
//TODO: actually check if the property exists.
6969
return true;
7070
}

‎nativescript-angular/http/ns-http.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import {Injectable} from '@angular/core';
2-
import {Http, XHRBackend, ConnectionBackend, RequestOptions, RequestOptionsArgs, ResponseOptions, ResponseType, Response, XSRFStrategy} from '@angular/http';
2+
import {Http, ConnectionBackend, RequestOptionsArgs, ResponseOptions, ResponseType, Response} from '@angular/http';
33
import {Observable} from 'rxjs/Observable';
44
import 'rxjs/add/observable/fromPromise';
55
import {NSFileSystem} from '../file-system/ns-file-system';
66

77
export class NSXSRFStrategy {
8-
public configureRequest(req: any) {
8+
public configureRequest(_req: any) {
99
// noop
1010
}
1111
}

0 commit comments

Comments
 (0)