Robust delombok: added directory filtering and argfile support for large projects

h4xr · h4xr · commit f904a275cb16 · 2026-04-06T00:47:37.000+05:30
diff --git a/src/main/java/com/neuvem/java2graph/passes/DelombokPass.java b/src/main/java/com/neuvem/java2graph/passes/DelombokPass.java
@@ -4,11 +4,14 @@
 import com.neuvem.java2graph.models.GraphContext;
 
 import java.io.BufferedReader;
+import java.io.BufferedWriter;
 import java.io.InputStreamReader;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
 
 public class DelombokPass implements Pass {
 
@@ -18,13 +21,29 @@ public void execute(Java2GraphConfig config, GraphContext context) throws Except
             return;
         }
 
-        System.out.println("Processing Lombok annotations via isolated process...");
+        System.out.println("Processing Lombok annotations via isolated process (filtering builds/hidden)...");
 
         Path delombokDir = Files.createTempDirectory("delombok");
         String javaHome = System.getProperty("java.home");
         String javaBin = javaHome + "/bin/java";
         String classpath = System.getProperty("java.class.path");
 
+        // Identify source directories while excluding build/hidden folders
+        List<String> srcPaths = findSourceDirs(config.getSrcDir());
+        if (srcPaths.isEmpty()) {
+            System.out.println("No Java source files found in " + config.getSrcDir());
+            return;
+        }
+
+        // Use a response file for delombok to avoid command-line length limits and manage inputs
+        Path argFile = Files.createTempFile("delombok_args", ".args");
+        try (BufferedWriter writer = Files.newBufferedWriter(argFile)) {
+            for (String path : srcPaths) {
+                writer.write("\"" + path.replace("\\", "\\\\") + "\"");
+                writer.newLine();
+            }
+        }
+
         List<String> command = new ArrayList<>();
         command.add(javaBin);
 
@@ -46,7 +65,9 @@ public void execute(Java2GraphConfig config, GraphContext context) throws Except
         command.add(classpath);
         command.add("lombok.launch.Main");
         command.add("delombok");
-        command.add(config.getSrcDir().toAbsolutePath().toString());
+        command.add("--nocopy");
+        command.add("--quiet");
+        command.add("@" + argFile.toAbsolutePath());
         command.add("-d");
         command.add(delombokDir.toAbsolutePath().toString());
 
@@ -58,11 +79,15 @@ public void execute(Java2GraphConfig config, GraphContext context) throws Except
         try (BufferedReader reader = new BufferedReader(new InputStreamReader(process.getInputStream()))) {
             String line;
             while ((line = reader.readLine()) != null) {
+                // Suppress verbose hidden directory messages from Lombok
+                if (line.contains("hidden directory")) continue;
                 output.append(line).append("\n");
             }
         }
 
         int exitCode = process.waitFor();
+        Files.deleteIfExists(argFile); // Clean up the temp args file
+
         if (exitCode != 0) {
             System.err.println("Delombok failed with exit code " + exitCode);
             System.err.println("--- Delombok Output ---");
@@ -76,4 +101,37 @@ public void execute(Java2GraphConfig config, GraphContext context) throws Except
         
         System.out.println("Lombok processing complete. Delomboked to: " + delombokDir);
     }
+
+    private List<String> findSourceDirs(Path root) throws Exception {
+        try (Stream<Path> walk = Files.walk(root)) {
+            return walk.filter(Files::isDirectory)
+                    .filter(path -> !isExcluded(path))
+                    .filter(this::hasJavaFiles)
+                    .map(path -> path.toAbsolutePath().toString())
+                    .collect(Collectors.toList());
+        }
+    }
+
+    private boolean isExcluded(Path path) {
+        for (Path part : path) {
+            String name = part.toString();
+            if (name.startsWith(".") || 
+                name.equals("build") || 
+                name.equals("target") || 
+                name.equals("bin") || 
+                name.equals("out") ||
+                name.equals("node_modules")) {
+                return true;
+            }
+        }
+        return false;
+    }
+
+    private boolean hasJavaFiles(Path dir) {
+        try (Stream<Path> files = Files.list(dir)) {
+            return files.anyMatch(p -> p.getFileName().toString().endsWith(".java"));
+        } catch (Exception e) {
+            return false;
+        }
+    }
 }
