get_by_batchref in abstract+real repo, and a new integration test for it [get_by_batchref]

hjwp · hjwp · commit 75b2751da7fe · 2024-03-01T15:05:12.000Z
diff --git a/src/allocation/adapters/repository.py b/src/allocation/adapters/repository.py
@@ -1,5 +1,6 @@
 import abc
 from typing import Set
+from allocation.adapters import orm
 from allocation.domain import model
 
 
@@ -17,6 +18,12 @@ def get(self, sku) -> model.Product:
             self.seen.add(product)
         return product
 
+    def get_by_batchref(self, batchref) -> model.Product:
+        product = self._get_by_batchref(batchref)
+        if product:
+            self.seen.add(product)
+        return product
+
     @abc.abstractmethod
     def _add(self, product: model.Product):
         raise NotImplementedError
@@ -25,6 +32,10 @@ def _add(self, product: model.Product):
     def _get(self, sku) -> model.Product:
         raise NotImplementedError
 
+    @abc.abstractmethod
+    def _get_by_batchref(self, batchref) -> model.Product:
+        raise NotImplementedError
+
 
 class SqlAlchemyRepository(AbstractRepository):
     def __init__(self, session):
@@ -36,3 +47,11 @@ def _add(self, product):
 
     def _get(self, sku):
         return self.session.query(model.Product).filter_by(sku=sku).first()
+
+    def _get_by_batchref(self, batchref):
+        return (
+            self.session.query(model.Product)
+            .join(model.Batch)
+            .filter(orm.batches.c.reference == batchref)
+            .first()
+        )
diff --git a/tests/integration/test_repository.py b/tests/integration/test_repository.py
@@ -0,0 +1,15 @@
+from allocation.adapters import repository
+from allocation.domain import model
+
+
+def test_get_by_batchref(session):
+    repo = repository.SqlAlchemyRepository(session)
+    b1 = model.Batch(ref="b1", sku="sku1", qty=100, eta=None)
+    b2 = model.Batch(ref="b2", sku="sku1", qty=100, eta=None)
+    b3 = model.Batch(ref="b3", sku="sku2", qty=100, eta=None)
+    p1 = model.Product(sku="sku1", batches=[b1, b2])
+    p2 = model.Product(sku="sku2", batches=[b3])
+    repo.add(p1)
+    repo.add(p2)
+    assert repo.get_by_batchref("b2") == p1
+    assert repo.get_by_batchref("b3") == p2
