Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NativeScript/v8-buildscripts
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: NativeScript/v8-buildscripts
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: android_x86
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 12 files changed
  • 2 contributors

Commits on Nov 14, 2022

  1. build x86 only

    vmutafov committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    15e706f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    32c714b View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. use api 17

    vmutafov committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    9b392c1 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. feat: remove option to build with external startup data, and tools bu…

    …ilds (x86) (#4)
    
    * Support NPM versions that don't export config environment variables
    
    The automatic exportation of environment variables based on the config key
    in package.json was removed in later versions of Node.js. Here, we
    manually set the environment variable if it's not automatically set.
    
    * Install ninja dep
    
    Ninja is a prerequisite for the build. On Ubuntu install it with apt-get,
    and on GitHub's macOS Docker image it needs to come from Homebrew.
    
    * Remove support for external startup data
    
    This makes V8 always build with v8_use_external_startup_data=false.
    Since that was previously controlled by the EXTERNAL_STARTUP_DATA
    variable, we can remove that variable. If we're not using external startup
    heap snapshots, we also don't need to export mksnapshot and mkcodecache;
    they are now only used internally by the V8 build. This also makes a
    TOOLS_ONLY build and therefore a tools_macos_android build obsolete.
    
    Summary:
    - Remove EXTERNAL_STARTUP_DATA
    - Remove TOOLS_ONLY
    - Remove MKSNAPSHOT_ONLY
    - Remove MKCODECACHE_ONLY
    - Remove patch to allow monolithic build with external startup data
    - Remove patch to export mkcodecache
    - Remove tools_macos_android workflow
    ptomato authored May 5, 2023
    Configuration menu
    Copy the full SHA
    e7aa7ed View commit details
    Browse the repository at this point in the history
Loading