Skip to content

livesync broken after PR #1740 #1818

Closed
Closed

Description

@dtopuzov

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 5.3.1
  • Cross-platform modules: 5.3.2
  • Android Runtime: 5.3.1
  • NativeScript-Angular: nativescript-angular@7.2.4-next-2019-05-10-092024-01

Describe the bug
Livesync changes cause app crash.

To Reproduce

npm i -g nativescript@5.3.1
tns create MyApp --template tns-template-master-detail-ng
cd MyApp
tns run android --bundle --hmr -> OK
Repalce `options.name;` with `"SyncTest";` in src\app\cars\shared\car.model.ts -> OK
Ctrl+C

npm un nativescript-angular --save
npm i nativescript-angular@7.2.4-next-2019-05-10-092024-01 --save --save-exact
tns run android --bundle --hmr -> OK
Repalce `options.name;` with `"SyncTest";` in src\app\cars\shared\car.model.ts -> Crash

Crash log:

Refreshing application on device emulator-5554...
System.err: com.tns.NativeScriptException:
System.err: Calling js method run failed
System.err:
System.err: TypeError: Cannot read property 'textTransform' of undefined
System.err: File: "file:///data/data/org.nativescript.MyApp/files/app/vendor.js, line: 79951, column: 24
System.err:
System.err: StackTrace:
System.err:     Frame: function:'createSpannableStringBuilder', file:'file:///data/data/org.nativescript.MyApp/files/app/vendor.js', line: 136084, column: 52
System.err:     Frame: function:'push.../node_modules/tns-core-modules/ui/text-base/text-base.js.TextBase.(anonymous function)', file:'file:///data/data/org.nativescript.MyApp/files/app/vendor.js', line: 135888, column: 38
System.err:     Frame: function:'push.../node_modules/tns-core-modules/ui/text-base/text-base-common.js.TextBaseCommon._onFormattedTextContentsChanged', file:'file:///data/data/org.nativescript.MyApp/files/app/vendor.js', line: 135706, column: 58
System.err:     Frame: function:'push.../node_modules/tns-core-modules/data/observable/observable.js.Observable.notify', file:'file:///data/data/org.nativescript.MyApp/files/app/vendor.js', line: 107857, column: 32

Expected behavior
Changes applied properly.

Additional context
Looks to be caused by #1740

Activity

  1. elena-p commented on May 14, 2019

    @elena-p
    Contributor

    the fix is in both release and master branches

  2. ghost removed on May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions