fix: mark V8Args.Length method as const

darind · darind · commit 5cc75b24072f · 2020-01-29T11:47:15.000+02:00
diff --git a/NativeScript/runtime/DataWrapper.h b/NativeScript/runtime/DataWrapper.h
@@ -37,7 +37,7 @@ enum class WrapperType {
 struct V8Args {
 public:
     virtual v8::Local<v8::Value> operator[](int i) const = 0;
-    virtual size_t Length() = 0;
+    virtual size_t Length() const = 0;
 };
 
 struct V8FunctionCallbackArgs: public V8Args {
@@ -50,7 +50,7 @@ struct V8FunctionCallbackArgs: public V8Args {
         return this->info_[i];
     }
 
-    size_t Length() override {
+    size_t Length() const override {
         return this->info_.Length();
     }
 private:
@@ -67,7 +67,7 @@ struct V8VectorArgs: public V8Args {
         return this->args_[i];
     }
 
-    size_t Length() override {
+    size_t Length() const override {
         return this->args_.size();
     }
 private:
@@ -84,7 +84,7 @@ struct V8SimpleValueArgs: public V8Args {
         return this->value_;
     }
 
-    size_t Length() override {
+    size_t Length() const override {
         return 1;
     }
 private:
@@ -97,7 +97,7 @@ struct V8EmptyValueArgs: public V8Args {
         return v8::Local<v8::Value>();
     }
 
-    size_t Length() override {
+    size_t Length() const override {
         return 0;
     }
 };

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ enum class WrapperType {`
`37`	`37`	`struct V8Args {`
`38`	`38`	`public:`
`39`	`39`	`virtual v8::Local<v8::Value> operator[](int i) const = 0;`
`40`		`- virtual size_t Length() = 0;`
	`40`	`+ virtual size_t Length() const = 0;`
`41`	`41`	`};`
`42`	`42`
`43`	`43`	`struct V8FunctionCallbackArgs: public V8Args {`
`@@ -50,7 +50,7 @@ struct V8FunctionCallbackArgs: public V8Args {`
`50`	`50`	`return this->info_[i];`
`51`	`51`	`}`
`52`	`52`
`53`		`- size_t Length() override {`
	`53`	`+ size_t Length() const override {`
`54`	`54`	`return this->info_.Length();`
`55`	`55`	`}`
`56`	`56`	`private:`
`@@ -67,7 +67,7 @@ struct V8VectorArgs: public V8Args {`
`67`	`67`	`return this->args_[i];`
`68`	`68`	`}`
`69`	`69`
`70`		`- size_t Length() override {`
	`70`	`+ size_t Length() const override {`
`71`	`71`	`return this->args_.size();`
`72`	`72`	`}`
`73`	`73`	`private:`
`@@ -84,7 +84,7 @@ struct V8SimpleValueArgs: public V8Args {`
`84`	`84`	`return this->value_;`
`85`	`85`	`}`
`86`	`86`
`87`		`- size_t Length() override {`
	`87`	`+ size_t Length() const override {`
`88`	`88`	`return 1;`
`89`	`89`	`}`
`90`	`90`	`private:`
`@@ -97,7 +97,7 @@ struct V8EmptyValueArgs: public V8Args {`
`97`	`97`	`return v8::Local<v8::Value>();`
`98`	`98`	`}`
`99`	`99`
`100`		`- size_t Length() override {`
	`100`	`+ size_t Length() const override {`
`101`	`101`	`return 0;`
`102`	`102`	`}`
`103`	`103`	`};`