fix: Correctly initialize context in inspector client init()

ptomato · ptomato · commit 0bc0480035d0 · 2023-03-06T16:24:39.000-08:00
I'm not sure about this, but I think the code was initializing context_
with its own initial value (i.e. nullptr), rather than the isolate's
context. This seemed to trigger an error when sending a message to the
frontend, which this change fixed.
diff --git a/test-app/runtime/src/main/cpp/JsV8InspectorClient.cpp b/test-app/runtime/src/main/cpp/JsV8InspectorClient.cpp
@@ -192,8 +192,7 @@ void JsV8InspectorClient::init() {
 
     inspector_->contextCreated(v8_inspector::V8ContextInfo(context, JsV8InspectorClient::contextGroupId, v8_inspector::StringView()));
 
-    v8::Persistent<v8::Context> persistentContext(context->GetIsolate(), JsV8InspectorClient::PersistentToLocal(isolate_, context_));
-    context_.Reset(isolate_, persistentContext);
+    context_.Reset(isolate_, context);
 
     this->createInspectorSession(isolate_, context);
 }

Original file line number	Diff line number	Diff line change
`@@ -192,8 +192,7 @@ void JsV8InspectorClient::init() {`
`192`	`192`
`193`	`193`	`inspector_->contextCreated(v8_inspector::V8ContextInfo(context, JsV8InspectorClient::contextGroupId, v8_inspector::StringView()));`
`194`	`194`
`195`		`- v8::Persistent<v8::Context> persistentContext(context->GetIsolate(), JsV8InspectorClient::PersistentToLocal(isolate_, context_));`
`196`		`- context_.Reset(isolate_, persistentContext);`
	`195`	`+ context_.Reset(isolate_, context);`
`197`	`196`
`198`	`197`	`this->createInspectorSession(isolate_, context);`
`199`	`198`	`}`