fix(android): Corrected TabView fragment manager resolution#11228
Open
CatchABus wants to merge 4 commits into
Open
fix(android): Corrected TabView fragment manager resolution#11228CatchABus wants to merge 4 commits into
CatchABus wants to merge 4 commits into
Conversation
|
View your CI Pipeline Execution ↗ for commit 0936186
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
This is the second attempt after #11217.
Apparently, entering tab item
loadedlifecycle during adapterattachis too early and tab frame fragments don't get enough time to be added to the correct fragment manager.What is the new behavior?
This PR takes a few things from ui-material tabs plugin:
loadedlifecycle is called at the right time (see line, commit)It seems we don't really need the material plugin approach for retrieving child fragment manager since adapter always adds/attaches fragments to
tabView._getFragmentManager(), so this PR uses the fragment tag to resolve the tab fragment directly and consequently the child fragment manager here.Fixes #10165.