Skip to content

ref(core): Application sdk css classes rework#11227

Open
CatchABus wants to merge 4 commits into
NativeScript:mainfrom
CatchABus:ref/css-sdk-classes
Open

ref(core): Application sdk css classes rework#11227
CatchABus wants to merge 4 commits into
NativeScript:mainfrom
CatchABus:ref/css-sdk-classes

Conversation

@CatchABus
Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

Right now, Application module contains a quite sloppy implementation of SDK version CSS classes.
Few things to note regarding the current implementation:

  • Core keeps a needless cache of these css classes in application module top-level
  • Core attempts to apply these classes to modal views during startup (there are no modals during app startup)
  • Core attempts to initialize these classes using a function that is specifically for initializing a11y CSS classes

What is the new behavior?

This PR removes what's not needed and follows core API for applying system CSS classes.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 24, 2026

View your CI Pipeline Execution ↗ for commit bc2d8f2

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 3m 40s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-24 09:12:00 UTC

Copy link
Copy Markdown
Collaborator

@farfromrefug farfromrefug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great this will help with moving a11 into a separated plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants