fix: Android 'isScrollEnabled' not applied to scroll view if changed during gesture#8695
Merged
Conversation
NathanWalker
approved these changes
Jul 6, 2020
Contributor
NathanWalker
left a comment
There was a problem hiding this comment.
Thank you @dimitrisrk
rigor789
approved these changes
Jul 6, 2020
|
Awesome thank you @dimitrisrk . I struggled with this issue for some time and I hope this will be released soon |
Contributor
|
Released with https://github.com/NativeScript/NativeScript/releases/tag/6.5.9 now |
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
…le gesture is underway (#8695)
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
…le gesture is underway (#8695)
tarunama
pushed a commit
to tarunama/NativeScript
that referenced
this pull request
Sep 9, 2020
…le gesture is underway (NativeScript#8695)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Android property 'isScrollEnabled' does not apply to scroll view if changed while gesture is underway.
What is the new behavior?
Android property 'isScrollEnabled' will apply to scroll view if changed while gesture is underway.
Fixes #8545 .
This fixes issues of implementations related to moving views inside a ScrollView (e.g. BottomSheet).
Here is a sample from @rigor789 that was done using android native touch listener: https://play.nativescript.org/?template=play-vue&id=v1t5Pe&v=2
With this fix, there is the possibility of implementing such features using pure NativeScript. :)