Repository navigation
fix(7986): nested css-calc and css-variables with fallback give incorrect result - #7987
Merged
manoldonev merged 5 commits intoNov 7, 2019
Merged
Conversation
Contributor
|
test |
manoldonev
approved these changes
Nov 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Nesting css-calc expressions with css-variable with fallback give the wrong result.
Assuming input value:
calc(calc(var(--undefined-var, 16) / 2) * 2)._evaluateCssVariableExpressionreturnscalc(calc(16) / 2) * 2)(note: the missing end-))_evaluateCssCalcExpressionreturns8 * 2).parseFloatwhich results in the number8.The problem is caused by
cssVariableExpressionRegexpfinding the wrong).What is the new behavior?
Fixes #7986.
css-variableexpressions.includes,indexOfandlastIndexOf.css-variableexpressions is now done from the end of the string, before it was done from the start.3b. This means the inner
css-variableis a nested expression is processed first, but this was the simplest way to find the correct end-)of those expressions.