Repository navigation
fix(iOS): Opening alert/confirm on top most of modal dialogs - #7982
Conversation
This is fix for the issue NativeScript#6939 where alert() and confirm() does not work in a modal dialog if it's opened on top of an existing modal dialog.
|
@ADjenkov, do you want me to update the branch? It looks the master is out of date and will it require re-approval? |
|
@slolam no need of re-approval. I'll update it now |
|
@ADjenkov, typically how many days does it take to merge and release after approval? I have been manually updating the framework file for this fix before I build the app for release. |
|
test |
The failed test output has java.lang.* I am wondering how my iOS related changes creeping into the Android world. Is there a way I could get access to the output/log of the test? |
|
@slolam sorry for the late response. Don't mind the test results for now, since we are facing some issues with testing on our side. Will try to merge it today, thanks for the PR! |
|
Hey, thanks for your contribution! We have a special program for our first-time contributors and you are eligible to participate in it. If you haven't applied already, all you need to do to claim your prize is to fill our Application Form. Regards from the whole team 🥇 |
This is fix for the issue #6939 where alert() and confirm() does not work in a modal dialog if it's opened on top of an existing modal dialog.
PR Checklist
What is the current behavior?
If you have modal dialog on top of another modal dialog (which is support from {N} 4.0), you cannot show an alert/confirm in iOS. It simply does not show the alert, it silently gives a warning. This is an iOS only behavior and is reported in the #6939.
Here is the link to the Playground https://play.nativescript.org/?template=play-ng&id=GeR8Q4&v=2
The alert box is shown on the first dialog but not on the stacked ones on top of it.
What is the new behavior?
It uses the top most UIViewController to present the alert/confirm
Fixes #6939.
This fix does not contain any breaking changes