Repository navigation
fix(ios-bot-nav): incorrect layout on orientation change - #7927
Merged
Merged
Conversation
MartoYankov
force-pushed
the
myankov/fix-tab-orientation-change
branch
from
October 9, 2019 11:44
27d50ac to
8476cb7
Compare
manoldonev
approved these changes
Oct 10, 2019
manoldonev
force-pushed
the
myankov/fix-tab-orientation-change
branch
from
October 22, 2019 15:58
7d7c996 to
9eb5cb4
Compare
Contributor
|
test --ignore uitests ios12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
On iOS the BottomNavigation didn't layout correctly on orientation change.
What is the new behavior?
On iOS the BottomNavigation now re-layouts the tab bar on orientation change.
Fixes #7864