feat(dark-mode): add system appearance property, event and CSS classes by vchimev · Pull Request #7887 · NativeScript/NativeScript

vchimev · 2019-10-01T08:25:33Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.

Implements

Detect system appearance at application launch:
expose a systemAppearance property to the application module,
Add ns-light/ns-dark CSS classes to the application root view,
Notify about a system appearance change:
expose a systemAppearanceChanged event

of #7800.

manoldonev

After addressing last comment.

…unch

This is because could not synchronize attachment in: - application module, - user's application. Do not attach on orientation changed and system appearance changed events. Insted, execute logic before notifying the registered listeners for the event.

cla-bot Bot added the cla: yes label Oct 1, 2019

vchimev requested review from MartoYankov, manoldonev and vakrilov and removed request for MartoYankov and manoldonev October 1, 2019 08:25

vchimev changed the title ~~feat(dark-mode): apply ns-light|ns-dark CSS classes to the application root view~~ feat(dark-mode): add ns-light|ns-dark CSS classes to the application root view Oct 1, 2019

vchimev requested review from ADjenkov and MartoYankov and removed request for vakrilov October 1, 2019 08:28

vchimev force-pushed the vchimev/system-mode branch from 15bec02 to d81be71 Compare October 3, 2019 05:17

vchimev mentioned this pull request Oct 3, 2019

[Tracking] Dark Mode Support #7800

Open

4 of 12 tasks

vchimev changed the title ~~feat(dark-mode): add ns-light|ns-dark CSS classes to the application root view~~ feat(dark-mode): add system appearance property, event and CSS classes Oct 3, 2019

vchimev commented Oct 3, 2019

View reviewed changes

Comment thread tns-core-modules/application/application.ios.ts

manoldonev reviewed Oct 3, 2019

View reviewed changes

Comment thread tns-core-modules/application/application-common.ts Outdated

manoldonev reviewed Oct 3, 2019

View reviewed changes

Comment thread tns-core-modules/application/application.android.ts Outdated

manoldonev reviewed Oct 3, 2019

View reviewed changes

Comment thread tns-core-modules/application/application.android.ts

manoldonev reviewed Oct 3, 2019

View reviewed changes

Comment thread tns-core-modules/application/application.android.ts Outdated

manoldonev reviewed Oct 3, 2019

View reviewed changes

Comment thread tns-core-modules/application/application.d.ts Outdated