Skip to content

feat(css): Add HSL/HSLA support - #7730

Merged
manoldonev merged 10 commits into
masterfrom
bundev/hsla-support
Sep 13, 2019
Merged

manoldonev merged 10 commits into
masterfrom
bundev/hsla-support

Conversation

@bundyo

@bundyo bundyo commented Aug 25, 2019 •

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

There is no HSL/HSLA support

What is the new behavior?

HSL/HSLA colors work, like this:

ActionBar {
    background-color: hsla(50, 50%, 50%, .8);
}

Fixes/Implements/Closes #7729.

No breaking changes.

@cla-bot cla-bot Bot added the cla: yes label Aug 25, 2019
@bundyo bundyo self-assigned this Aug 25, 2019

@m-abs m-abs left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to review (I'm just a contributor), since it was a my issue for nativescript-theme-core that triggered this :)

LGTM. I had a few minor comments, and I think you should add some tests for hsl/hsla to unit-tests/css/parser.ts

Comment thread tns-core-modules/color/color-common.ts
Comment thread tns-core-modules/css/parser.ts Outdated
@bundyo

bundyo commented Aug 26, 2019

Copy link
Copy Markdown
Contributor Author

Added two tests (as there are only two for every color space). 🙂

@ADjenkov
ADjenkov self-requested a review September 10, 2019 10:48
@manoldonev
manoldonev merged commit 3cabdde into master Sep 13, 2019
@manoldonev
manoldonev deleted the bundev/hsla-support branch September 13, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add HSL/HSLA CSS color support

5 participants