Rename cssClass property to just class #766

Activity

1. tjvantoll commented on Sep 17, 2015

   

   tjvantoll

   on Sep 17, 2015

   Contributor

   More actions

   👍

   I've always thought cssClass was an odd name. I should've asked for this myself a while ago.
2. ligaz commented on Sep 17, 2015

   

   ligaz

   on Sep 17, 2015

   ContributorAuthor

   More actions

   We should note that on the JavaScript side it is called className.
3. manijak commented on Sep 17, 2015

   

   manijak

   on Sep 17, 2015

   More actions

   Reminds me of .net WebForms :) But classis better.

   <asp:TextBox id="TextBox1" ForeColor="Red" CssClass="class1" />
4. enchev

   self-assigned this

   on Sep 18, 2015
5. enchev

   added this to the 1.4.0 milestone on Sep 18, 2015
6. enchev commented on Sep 18, 2015

   

   enchev

   on Sep 18, 2015

   Contributor

   More actions

   I've made it just because the new picture of @akorchev! :)
7. akorchev commented on Sep 18, 2015

   

   akorchev

   on Sep 18, 2015

   More actions

   Now rename the JavaScript cssClass property to className (or deprecate cssClass in favor of className).
8. enchev commented on Sep 18, 2015

   

   enchev

   on Sep 18, 2015

   Contributor

   More actions

   @akorchev Done!
9. akorchev commented on Sep 18, 2015

   

   akorchev

   on Sep 18, 2015

   More actions

   !!
10. akorchev commented on Sep 18, 2015

    

    akorchev

    on Sep 18, 2015

    More actions

    I know that I am pushing this but what about tap="" vs ontap=""? The on prefix is something web developers understand well.
11. enchev commented on Sep 18, 2015

    

    enchev

    on Sep 18, 2015

    Contributor

    More actions

    @akorchev Here you go:36036c5 :)
12. enchev

    added

    done

    feature

    on Sep 18, 2015
13. enchev

    closed this as completedon Sep 18, 2015
14. tjvantoll commented on Sep 18, 2015

    

    tjvantoll

    on Sep 18, 2015

    Contributor

    More actions

    Wow, this is awesome! @akorchev You should keep asking for things :)
15. hshristov

    added

    in progress

    severity: low

    breaking-change

    and removed

    done

    on Sep 22, 2015
16. hshristov commented on Sep 22, 2015

    

    hshristov

    on Sep 22, 2015

    Contributor

    More actions

    @enchev Now we need to do the hard work to describe this change in the documentation & in help articles (cssClass rename, tap -> onTap). I'm marking this as a breaking change because if someone have by any chance exposed his event as 'onEvent' in 1.3 from 1.4 he will need to use 'ononEvent' in the XML.
17. hshristov

    reopened this on Sep 22, 2015
18. enchev commented on Sep 23, 2015

    

    enchev

    on Sep 23, 2015

    Contributor

    More actions

    Just to clear what I've done in my pull request to avoid further confusion:

    • cssClass property is not removed and you can still use it from both XML and JavaScript
    • I've added new custom attribute class for all view that can be used only from XML
    • event names are not removed or renamed and you can still use tap, doubleTap, etc.:

      <Button tap="myTap" />

    Now you can use also more familiar to web devs syntax with on prefix:

      <Button ontap="myTap" />

    Both are valid!
19. enchev commented on Sep 28, 2015

    

    enchev

    on Sep 28, 2015

    Contributor

    More actions

    I've updated the docs to use class instead cssClass and I've added special section to our declarative UI with XML article.
20. enchev

    closed this as completedon Sep 28, 2015
21. lock commented on Aug 30, 2019

    

    lockbot

    on Aug 30, 2019

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
22. lock

    locked and limited conversation to collaborators on Aug 30, 2019