Skip to content

fix(tabs-ios): unable to return to tab after tab with nested frame visited - #7574

Merged
SvetoslavTsenov merged 26 commits into
releasefrom
djenkov/preload-ios-tabs
Jul 25, 2019
Merged

SvetoslavTsenov merged 26 commits into
releasefrom
djenkov/preload-ios-tabs

Conversation

@ADjenkov

@ADjenkov ADjenkov commented Jul 24, 2019 •

Copy link
Copy Markdown
Contributor

Postpone load/unload until UIPageViewController animation between 'pages' completes
Note: If nested frame available inside TabContentItem, it will be shown just after animation completes.

Includes rebase of mdonev/tabs-bottom-nav-e2e branch

Fix #7564

@ADjenkov ADjenkov self-assigned this Jul 24, 2019
@cla-bot cla-bot Bot added the cla: yes label Jul 24, 2019
@ADjenkov

Copy link
Copy Markdown
Contributor Author

test --ignore branch-nested-frame-navigation#mdonev/tabs-bottom-nav-e2e api23 ios12 uitests

@ADjenkov
ADjenkov force-pushed the djenkov/preload-ios-tabs branch from 9638f37 to 4cb8041 Compare July 24, 2019 14:46
@SvetoslavTsenov
SvetoslavTsenov merged commit 490cab0 into release Jul 25, 2019
@SvetoslavTsenov
SvetoslavTsenov deleted the djenkov/preload-ios-tabs branch July 25, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants