Repository navigation
feat(list-picker): add textField, valueField and selectedValue properties - #6033
Merged
Merged
Conversation
textField and valueField - should be used with arrays of JSON objects textField - tells the listview which property should be used to display each item valueField - tells the listview, which property should be used to update the selectedValue selectedValue - is the property that will contain the selectedValue, if valueField is specified, then it will contain the value from that field, otherwise it will contain the whole selected item
|
Please sign CLA at http://www.nativescript.org/cla |
|
CLA signature found, happy contributing! |
Contributor
Author
|
An example of using the new properties: <ListPicker items="{{ items }}"
textField="name"
valueField="role"
selectedIndex="2"
selectedValue="{{ selectedItem }}">
</ListPicker> |
MartoYankov
approved these changes
Jul 23, 2018
|
It's unclear how I've tried various ways: Doesnt seem to do anything. Another thing. Binding the component via reactive forms will still bind just the index, and not the |
|
When is Angular coming next? |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Currently if we pass and array of json objects to a listview, there is no simple way to make it display a specific field from each item.
Also, we can only get the selectedIndex, but there is no direct way to get the selected object, or even specify which property should be returned.
What is the new behavior?
Implements #1677
Adds new properties to the ListView component (
textFieldandvalueField- should be used with arrays of JSON objects):textField- tells the listview which property should be used to display each itemvalueField- tells the listview, which property should be used to update the selectedValueselectedValue- is the property that will contain the selectedValue, ifvalueFieldis specified, then it will contain the value from that property, otherwise it will contain the whole selected itemBreaking changes
No breaking changes.
Demo app
I've added a sample in apps -> list-picker -> list-picker-json-array