Repository navigation
fix(android/text ios/text): allow -1 to be a valid binding value - #5563
Merged
Merged
Conversation
Instead of using -1 as special value, use Symbol(-1) so that it can't be reset accidentally Closes issue #5559
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Member
Author
|
I ran the tests. All the tests have passed :) And this PR doesn't require any new test case.
|
Contributor
|
test |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using -1 as a special value, use Symbol(-1)
so that it can't be reset accidentally
Closes issue #5559
PR Checklist
What is the current behavior?
#5559
What is the new behavior?
Replaced -1 with Symbol(-1) so that it reset can't be set accidentally
Fixes/Implements/Closes #[Issue Number].
#5556