Css gradients by vultix · Pull Request #5534 · NativeScript/NativeScript

vultix · 2018-03-13T19:58:33Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.

What is the current behavior?

No support for css gradients.

What is the new behavior?

Css properties background and background-gradient now support the CSS linear-gradient spec.
I.E.:

background: linear-gradient(to top, red, green, blue);
background: linear-gradient(20deg, red, green, blue);
background: linear-gradient(to bottom left, red 10%, green 40%, blue 90%);
background-image: /* Same as above */

Fixes #539

Note: this PR is dependent upon PR #116 on the tns-core-modules-widgets project. The changes will be breaking on android without this PR.

… applied to style.

ns-bot · 2018-03-13T19:58:35Z

Can one of the admins verify this patch?

ns-bot · 2018-03-13T19:58:35Z

Can one of the admins verify this patch?

ns-bot · 2018-03-13T19:58:36Z

Can one of the admins verify this patch?

pana-cc

Looks great,
Just one thing, can you extend the background-image type, rather than introducing a new property. I think the CSS spec the linear-gradient radial-gradient etc. are part of the possible values for a background-image.

Otherwise looks great.
Thank you for your contribution, this was one of the things I really wanted to see implemented in {N}.

pana-cc · 2018-03-14T08:54:13Z

    public background: string;
    public backgroundColor: Color;
    public backgroundImage: string;
+    public backgroundGradient: string;


In the CSS spec the gradients (linear and radial) are set on the background image:
https://developer.mozilla.org/en-US/docs/Web/CSS/background-image
There is no background-gradient property.

pana-cc · 2018-03-14T08:56:16Z

+        return true;
+    }
+}
+export const backgroundGradientProperty = new CssProperty<Style, LinearGradient>({


Again, I think this should be extending the type of the background-image instead of introducing a new property.

I've just committed this fix, could you give it another look?

… gradient to background-image.

pana-cc

Looks good! :)
I wonder if the background-image should remain string or be promoted to string | LinearGradient, but either way I am ok with it.

vakrilov · 2018-03-15T14:40:20Z

Thanks @vultix - this is an awesome feature.

We are going to run our internal CI tests over this PR and do a code review in the following days so expect updates!

vakrilov · 2018-03-15T14:43:06Z

+    }
+}
+
+


There is а tslint error caused by this line:
ERROR: tns-core-modules/ui/styling/linear-gradient.ts[61, 1]: Consecutive blank lines are forbidden

vakrilov · 2018-03-15T15:45:44Z

test

manoldonev · 2018-03-26T14:35:05Z

test branch_functional_tests#css-gradients-tests branch_widgets#vultix/css-gradients

SvetoslavTsenov · 2018-03-27T08:44:33Z

test branch_functional_tests#css-gradients-tests branch_widgets#vultix/css-gradients

SvetoslavTsenov · 2018-03-27T11:50:25Z

Hey @vultix, thank you for your contribution and especially additional tests cases included in uitests app.
We have run some checks on our CI and it appears that there are some failures. I will give a short description of the problems we have encountered.

Android related issues:
Our tests are triggered mainly on api 19 and api 23

Unit tests :
=== ALL TESTS COMPLETE ===I/JS ( 4364): 1486 OK, 45 failedI/JS ( 4364): DURATION: 116354.30 msI/JS ( 4364): === END OF TESTS ===E/JS ( 4364): Test: STYLE-PROPERTIES.test_setting_backgroundImage_property_from_CSS_is_applied_to_Style FAILED: Cannot read property 'match' of undefinedE/JS ( 4364): Test: STYLE-PROPERTIES.test_setting_backgroundImage_gradient_property_from_CSS_is_applied_to_Style FAILED: Setting property backgroundImage with CSS name background-image Actual: <[object Object]>(object). Expected: <linear-gradient(to top, red, blue)>(string)E/JS ( 4364): Test: VIEW.testBackgroundImage FAILED: Cannot read property 'match' of undefinedE/JS ( 4364): Test: VIEW.test_background_image_doesnt_throw FAILED: Cannot read property 'match' of undefinedE/JS ( 4364): Test: STYLE.test_css_dataURI_is_applied_to_backgroundImageSource FAILED: Cannot read property 'match' of undefinedE/JS ( 4364): Test: STYLE.test_css_is_applied_to_normal_properties FAILED: Cannot read property 'match' of undefinedE/JS ( 4364): Test: STYLE.test_css_is_applied_to_special_properties FAILED: Cannot read property 'match' of undefinedE/JS ( 4364): Test: STYLE.test_applies_css_changes_to_application_rules_before_page_load FAILED: Cannot read property 'match' of undefinedE/JS ( 4364): Test: STYLE.test_applies_css_changes_to_application_rules_after_page_load FAILED: Cannot read property 'match' of undefinedE/JS ( 4364): Test: STYLE.test_applies_css_changes_to_application_rules_after_page_load_new_views FAILED: Cannot read property 'match' of undefinedE/JS ( 4364)

2.UI tests agains uitest app. _ ### stackTrace: An uncaught 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS 03-27 09:24:51.186 5308 5308 I JS (background-shorthand example, background and etc) Most of the exception that we get there is "match of undefined in refreshBorderDrawable". This is the stack trace:
Exception occurred on "main" thread.
: com.tns.NativeScriptException:
: Calling js method onCreateView failed
:
: TypeError: Cannot read property 'match' of undefined
: File: "file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/styling/background.js, line: 118, column: 32
:
: StackTrace:
: Frame: function:'refreshBorderDrawable', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/styling/background.js', line: 118, column: 33
: Frame: function:'onBackgroundOrBorderPropertyChanged', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/styling/background.js', line: 55, column: 17
: Frame: function:'View._redrawNativeBackground', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view/view.js', line: 588, column: 29
: Frame: function:'View.(anonymous function)', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view/view.js', line: 568, column: 14
: Frame: function:'applyAllNativeSetters', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/properties/properties.js', line: 978, column: 37
: Frame: function:'initNativeView', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/properties/properties.js', line: 905, column: 9
: Frame: function:'ViewBase.onResumeNativeUpdates', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 627, column: 22
: Frame: function:'ViewBase._resumeNativeUpdates', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 272, column: 18
: Frame: function:'ViewBase.onLoaded', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 231, column: 14
: Frame: function:'View.onLoaded', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view/view.js', line: 193, column: 35
: Frame: function:'', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 311, column: 90
: Frame: function:'ViewBase.callFunctionWithSuper', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 304, column: 9
: Frame: function:'ViewBase.callLoaded', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 311, column: 14
: Frame: function:'ViewBase.loadView', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 439, column: 18
: Frame: function:'', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 233, column: 19
: Frame: function:'LayoutBaseCommon.eachChildView', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/layouts/layout-base-common.js', line: 125, column: 26
: Frame: function:'ViewCommon.eachChild', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view/view-common.js', line: 857, column: 14
: Frame: function:'ViewBase.onLoaded', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 232, column: 14
: Frame: function:'View.onLoaded', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view/view.js', line: 193, column: 35
: Frame: function:'', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 311, column: 90
: Frame: function:'ViewBase.callFunctionWithSuper', file:'file:///data/data/org.nativescript.apps/files/app/tns_modul
: es/tns-core-modules/ui/core/view-base/view-base.js', line: 304, column: 9
: Frame: function:'ViewBase.callLoaded', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 311, column: 14
: Frame: function:'ViewBase.loadView', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 439, column: 18
: Frame: function:'', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 233, column: 19
: Frame: function:'ContentView.eachChildView', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/content-view/content-view.js', line: 70, column: 13
: Frame: function:'PageBase.eachChildView', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/page/page-common.js', line: 120, column: 40
: Frame: function:'ViewCommon.eachChild', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view/view-common.js', line: 857, column: 14
: Frame: function:'ViewBase.onLoaded', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 232, column: 14
: Frame: function:'View.onLoaded', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view/view.js', line: 193, column: 35
: Frame: function:'Page.onLoaded', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/page/page.js', line: 43, column: 35
: Frame: function:'', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 311, column: 90
: Frame: function:'ViewBase.callFunctionWithSuper', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 304, column: 9
: Frame: function:'ViewBase.callLoaded', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 311, column: 14
: Frame: function:'ViewBase.loadView', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 439, column: 18
: Frame: function:'ViewBase._addViewCore', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 434, column: 18
: Frame: function:'ViewBase._addView', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/core/view-base/view-base.js', line: 420, column: 14
: Frame: function:'FragmentCallbacksImplementation.onCreateView', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/frame/frame.js', line: 576, column: 24
: Frame: function:'FragmentClass.onCreateView', file:'file:///data/data/org.nativescript.apps/files/app/tns_modules/tns-core-modules/ui/frame/fragment.js', line: 27, column: 38

IOS related issues:
Tested on simulators iOS 11.2

Unit tests:
=== ALL TESTS COMPLETE ===1540 OK, 1 failedDURATION: 48690.60 ms=== END OF TESTS ===2018-03-27 12:00:50.678250+0300 0x132881 Default 0x0 55651 tests: (NativeScript) CONSOLE ERROR file:///app/tns_modules/tns-core-modules/trace/trace.js:165:30: "Test: STYLE-PROPERTIES.test_setting_backgroundImage_gradient_property_from_CSS_is_applied_to_Style FAILED: Setting property backgroundImage with CSS name background-image Actual: <[object Object]>(object). Expected: <linear-gradient(to top, red, blue)>(string)"2018-03-27 12:00:50.678364+0300 0x132881 Default 0x0 55651 tests: (NativeScript) CONSOLE INFO file:///app/tns_modules/tns-core-modules/trace/trace.js:159:29: Test: Tests EOF!

Please let me know if you need some additional information.

vultix · 2018-03-27T14:45:39Z

@SvetoslavTsenov My apologies for those problems. I have been unable to run the test app on android due to a strange error.

That aside, I have found the problem causing "match of undefined in refreshBorderDrawable" and have pushed that fix in.

SvetoslavTsenov · 2018-03-28T07:48:11Z

That's ok! I will rerun tests.

SvetoslavTsenov · 2018-03-28T07:48:17Z

test branch_functional_tests#css-gradients-tests branch_widgets#vultix/css-gradients

SvetoslavTsenov · 2018-03-28T10:45:14Z

Hey @vultix, great job! All tests on our CI has passed successfully. I will try to cover few scenarios more and confirm new images that we are going to use for verification as soon as possible.

SvetoslavTsenov · 2018-04-23T11:43:01Z

test branch_functional_tests#css-gradients-tests branch_widgets#vultix/css-gradients

ADjenkov · 2018-04-25T13:38:26Z

@vultix I've created a PR to your fork with:

New test app for backgroundImage with various linear gradients
Minor change in equals method to enable setting new gradient.

chore(linear-gradient): fix equality comparer

ADjenkov · 2018-05-02T07:55:01Z

@vultix could you rebase to master branch since there are some very minor changes?
Thanks!

Fixed

ADjenkov · 2018-05-03T08:12:25Z

test branch_functional_tests#css-gradients-tests branch_widgets#vultix/css-gradients

SvetoslavTsenov · 2018-05-03T08:48:59Z

test branch_widgets#vultix/css-gradients

SvetoslavTsenov · 2018-05-03T10:23:19Z

Merging this PR, since the failures are related to the newly added UI test.

sitefinitysteve · 2018-05-03T13:23:16Z

Thanks for this one team!

This reverts commit 5a83a1c.

jlooper · 2018-05-23T14:26:26Z

This is awesome!! I'd be happy to send you a swag package in honor of this great PR! @vultix please email me with your t-shirt size if you'd like! jen.looper @ progress.com

william-levi · 2018-05-26T15:47:53Z

so, how to use this ? sorry for the noob question

datanotion · 2018-06-01T05:16:31Z

I'm getting an error similar to what was mentioned above: #5534 (comment)

"imageUri.match is not a function"

StackTrace: 
Frame: function:'refreshBorderDrawable', file:'file:///data/data/com.app.myapp/files/app/tns_modules/tns-core-modules/ui/styling/background.js', line: 99, column: 34

I just added a line of code from the examples to a panel:

background: linear-gradient(to top, red, green, blue);

I'll open an official ticket once I search around for a solution more.

yamchi · 2018-06-01T05:19:01Z

@datanotion yeah i also did that
background: linear-gradient(to top, red, green, blue);
but it's not working

JillevdW · 2018-06-11T13:50:20Z

For everyone looking for documentation on how to use the gradients, the link in the 4.1 release post is broken, this link works: https://docs.nativescript.org/cookbook/ui/styling#gradients

tenluap · 2018-06-12T12:50:11Z

css gradient not working ,
on nv(nativescript-vue)

abhayastudios · 2018-06-23T15:06:40Z

@vultix Wow thanks a lot for this! I was wondering how difficult would it be to have the gradients work on the action bar as well?

lock · 2019-08-26T09:54:24Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

vultix added 8 commits March 13, 2018 11:08

feat(ios): Added support for css gradients.

ade6093

feat(android): Added support for css gradients.

9c18483

fix: Fixed gradient borders on ios

0497f8d

fix(gradient): added backgroundGradient to View and Style.

ffe37f9

fix(ios-gradients): fixed ios gradients covering view content.

8da3d25

test(gradient): Added ui app tests for background gradients.

1975f8f

test(gradient): Added a test ensuring background gradient property is…

7157303

… applied to style.

style(gradient): Fixed tslint errors.

84eb967

ghost added the ♥ community PR label Mar 13, 2018

ns-bot added the cla: yes label Mar 13, 2018

vultix mentioned this pull request Mar 13, 2018

feat(android): added ability to create background linear gradients. NativeScript/tns-core-modules-widgets#116

Merged

pana-cc suggested changes Mar 14, 2018

View reviewed changes

fix(gradient): Removed the background-gradient property and added the…

8bf2f15

… gradient to background-image.

pana-cc approved these changes Mar 14, 2018

View reviewed changes

vakrilov previously requested changes Mar 15, 2018

View reviewed changes

style: fixed a consecutive blank line tslint error.

a9a7a02

fix(tests): fixed the bug that was causing tests to fail.

f3b84f8

Merge branch 'master' into css-gradients

770fab4

Merge branch 'master' into css-gradients

ea0cb2d

ADjenkov added 2 commits April 25, 2018 15:57

chore(linear-gradient): fix equality comparer

fe432d3

test(gradient): add linear gradients test app

39d47d5

ADjenkov self-requested a review April 25, 2018 13:46

ADjenkov approved these changes Apr 25, 2018

View reviewed changes

Merge pull request #1 from ADjenkov/linear-gradients

c0f7447

chore(linear-gradient): fix equality comparer

Merge branch 'master' into css-gradients

8dccc70

ghost assigned ADjenkov May 3, 2018

chore(tslint): update with latest tslint rules

b562368

SvetoslavTsenov merged commit 5a83a1c into NativeScript:master May 3, 2018

ghost removed the in progress label May 3, 2018

ADjenkov added a commit that referenced this pull request May 3, 2018

Revert "Css gradients (#5534)"

bdb91a0

This reverts commit 5a83a1c.

ADjenkov mentioned this pull request May 3, 2018

Revert "Css gradients" #5772

Merged

lock Bot locked and limited conversation to collaborators Aug 26, 2019

Conversation

vultix commented Mar 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

What is the current behavior?

What is the new behavior?

Uh oh!

ns-bot commented Mar 13, 2018

Uh oh!

ns-bot commented Mar 13, 2018

Uh oh!

ns-bot commented Mar 13, 2018

Uh oh!

pana-cc left a comment

Choose a reason for hiding this comment

Uh oh!

pana-cc Mar 14, 2018

Choose a reason for hiding this comment

Uh oh!

pana-cc Mar 14, 2018

Choose a reason for hiding this comment

Uh oh!

vultix Mar 14, 2018

Choose a reason for hiding this comment

Uh oh!

pana-cc left a comment

Choose a reason for hiding this comment

Uh oh!

vakrilov commented Mar 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vakrilov Mar 15, 2018

Choose a reason for hiding this comment

Uh oh!

vakrilov commented Mar 15, 2018

Uh oh!

manoldonev commented Mar 26, 2018

Uh oh!

SvetoslavTsenov commented Mar 27, 2018

Uh oh!

SvetoslavTsenov commented Mar 27, 2018

Uh oh!

vultix commented Mar 27, 2018

Uh oh!

SvetoslavTsenov commented Mar 28, 2018

Uh oh!

SvetoslavTsenov commented Mar 28, 2018

Uh oh!

SvetoslavTsenov commented Mar 28, 2018

Uh oh!

SvetoslavTsenov commented Apr 23, 2018

Uh oh!

ADjenkov commented Apr 25, 2018

Uh oh!

ADjenkov commented May 2, 2018

Uh oh!

ADjenkov commented May 3, 2018

Uh oh!

SvetoslavTsenov commented May 3, 2018

Uh oh!

SvetoslavTsenov commented May 3, 2018

Uh oh!

sitefinitysteve commented May 3, 2018

Uh oh!

jlooper commented May 23, 2018

Uh oh!

william-levi commented May 26, 2018

Uh oh!

datanotion commented Jun 1, 2018

"imageUri.match is not a function"

Uh oh!

yamchi commented Jun 1, 2018

Uh oh!

JillevdW commented Jun 11, 2018

Uh oh!

tenluap commented Jun 12, 2018

Uh oh!

abhayastudios commented Jun 23, 2018

Uh oh!

lock Bot commented Aug 26, 2019

vultix commented Mar 13, 2018 •

edited

Loading

vakrilov commented Mar 15, 2018 •

edited

Loading