Repository navigation
Enable overlap for custom transitions #4464
Description
When using a custom transition for android (example), these lines that make overlap possible for both fragments are never called.
Possible fix:
Adding the same logic before this line if the sdk version is greater than 21
i can summit a pr for this if it's ok with the team
Which platform(s) does your issue occur on?
- Android
- CLI: 3.0.4
- Cross-platform modules: 3.0.1
- Runtime(s): 3.0.1
Activity
NickIliev commentedon Jun 28, 2017
@danielgek we are always happy to receive PRs from our community members! Please take a look at our contributing guide and let me know if you need any assistance on that matter.
hshristov commentedon Jul 3, 2017
Hi @danielgek,
I'm in the process of rewriting most of
transition.android.tsso I will add your change in my PR. Otherwise it will be hard for me to rebase over your changes. Are you ok with this plan?danielgek commentedon Jul 3, 2017
@hshristov yes, no problem at all ;)
hshristov commentedon Jul 3, 2017
@danielgek I forgot to mention that while these APIs are called for lollipop transitions (e.g. API21+) they should not affect custom animation like the one you are doing (e.g. extending our Transition class produce android.animation.Animator instance, not android.transition.Transition)
danielgek commentedon Jul 3, 2017
@hshristov i see, but there is way of enabling overlap using android.animation.Animator instance ? can you include that on your rework ?
hshristov commentedon Jul 19, 2017
@danielgek In my opinion they are overlapped by default.
danielgek commentedon Aug 8, 2017
Hi @hshristov sorry for the late response, only now i find a little time to read the android documentation more carefully and yes you are right, my bad!
lock commentedon Aug 27, 2019
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.