Skip to content

verticalAlignment "middle" and "center" crash the app on Android #1822

Closed

Description

@alg

We discovered that these two values crash the app on Android. I found that it happens because of bad case-statement that looks like this:

case VerticalAlignment.center || VerticalAlignment.middle:

The default case picks up everything that doesn't match and raises an error for an unrecognized option.

Affected files:

  • ui/core/view.android.ts
  • ui/core/view-common.ts
  • ui/layouts/stack-layout/stack-layout.ios.ts

I'm submitting PR to resolve this in a minute.

Activity

  1. added this to the milestone on Mar 22, 2016
  2. lock commented on Aug 30, 2019

    @lock

    This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

  3. locked and limited conversation to collaborators on Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions