Repository navigation
listview android bug and fix #1371
Description
Background :
- Load item 50, "realizedItems" is 6, this is the item cached to display at the screen
- Filter the array to 5, scroll up, it will crash because realizedItems>new array
Solution : (list-view.android.js)
ListView.prototype._notifyScrollIdle = function () {
var keys = Object.keys(this._realizedItems);
var i;
var length = keys.length;
var view;
var key;
for (i = 0; i < length; i++) {
key = keys[i];
view = this._realizedItems[key];
if (view[REALIZED_INDEX]<this.items.length) // FIX
this.notify({
eventName: ITEMLOADING,
object: this,
index: view[REALIZED_INDEX],
view: view
});
}
};
IOS is working fine
(EDITED because the first fix is still getting error @Lollipop)
Activity
enchev commentedon Feb 4, 2016
Hey @x4080,
Why not submit pull request with the fix?
x4080 commentedon Feb 4, 2016
because i dont know how :)
ErjanGavalji commentedon Feb 4, 2016
@x4080, I can lend a hand with that or I can do the pull request for you. I'd recommend you do it to get the full credits of contributing to the open-source project. I'll be glad to assist... Let me know which one you prefer.
x4080 commentedon Feb 4, 2016
just do it, you guys have this wonderful work and let others to use it, already great things by itself, this is a little tiny contribution for ns community, so you have my blessing :)
ErjanGavalji commentedon Feb 4, 2016
@x4080, thanks for the kind words :)
Can I only ask you to sign our CLA? (Sorry for having to cause that inconvenience...)
Cheers,
Erjan
lock commentedon Aug 30, 2019
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.