Why are iOS modal animations disabled by default? Can we pass an option to enable it?

NativeScript/ui/page/page.ios.ts

Line 229 in fabe0ba

    
           parent.ios.presentViewControllerAnimatedCompletion(this._ios, false, function completion() {

NativeScript/ui/page/page.ios.ts

Line 238 in fabe0ba

parent._ios.dismissModalViewControllerAnimated(false);

Will be animated in iOS 9 and above!

Shouldn't there be an overload for showModal that accepts a NavigationEntry?

This would allow you to control the modal animation and possibly use a page factory to generate the modal view page. Does this make sense? Or am I crazy? :)

@toddanglin

Hey @toddanglin,

We believe that our modal pages should not be part of the navigation stack - you cannot navigate to a modal page.

That makes sense.

I was looking at it from the view of providing a way to specify the transitions (iOS/Android/Default) when showing a modal view, and possibly to provide the ability to dynamically generate a modal view (the create function). Is there a better/different way to do this with modals?

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Navigation Menu

Repository navigation

Why are iOS modal animations disabled by default? Can we pass an option to enable it? #1129

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Why are iOS modal animations disabled by default? Can we pass an option to enable it? #1129

Description

Activity

enchev commented on Feb 12, 2016

toddanglin commented on Feb 19, 2016

enchev commented on Feb 22, 2016

toddanglin commented on Feb 22, 2016

lock commented on Aug 30, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions